#61 [feat] GET - 글모임별 글감 카테고리 조회 #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sohyundoh
reviewed
Jan 11, 2024
sohyundoh
reviewed
Jan 11, 2024
| final Long moimId | ||
| ) { | ||
| List<CategoryResponse> categoryList = topicService.getKeywordsFromMoim(moimId); | ||
| return CategoryListResponse.of(categoryList); |
There was a problem hiding this comment.
P2
변수선언 없이 한 문장으로 할 수 있지 않을까요?
| public List<CategoryResponse> getKeywordsFromMoim( | ||
| final Long moimId | ||
| ) { | ||
| List<Topic> topicList = findByMoimId(moimId); |
There was a problem hiding this comment.
P1
길이가 0일 경우 예외 처리를 해야할 것 같습니다!
There was a problem hiding this comment.
앗 네 isKeywordsEmpty 에서 0인 경우 예외처리를 하고 있습니다!
parkheeddong
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✒️ 관련 이슈번호
Key Changes 🔑
글모임별 글감 카테고리 조회 로직을 구현했습니다!
To Reviewers 📢
글감 키워드가 존재하지 않는 경우 예외를 던져 주었습니다!
