-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#61 [feat] GET - 글모임별 글감 카테고리 조회 #65
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
4a8f858
#61 [feat] 컨트롤러 및 스웨거 인터페이스 구현
parkheeddong f54c8bc
#61 [feat] 성공 메시지 추가
parkheeddong 23136e0
#61 [feat] 반환 DTO 생성
parkheeddong e7b292f
#61 [feat] 키워드를 카테고리로 가져오는 서비스 로직 구현
parkheeddong 57e862d
#61 [refactor] @PathVariable 추가
parkheeddong 752d138
#61 [refactor] 글감 키워드가 존재하지 않는 경우 예외 처리
parkheeddong cac37a3
#39 [refactor] 변수 선언 없이 한 문장으로 변경
parkheeddong c9fc1b6
#61 [fix] conflict 해결
parkheeddong File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 changes: 11 additions & 0 deletions
11
module-domain/src/main/java/com/mile/moim/serivce/dto/CategoryListResponse.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
package com.mile.moim.serivce.dto; | ||
|
||
import com.mile.topic.serivce.dto.CategoryResponse; | ||
import java.util.List; | ||
|
||
public record CategoryListResponse(List<CategoryResponse> categoryList) { | ||
public static CategoryListResponse of(final List<CategoryResponse> categoryList) { | ||
return new CategoryListResponse(categoryList); | ||
} | ||
} | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 changes: 9 additions & 0 deletions
9
module-domain/src/main/java/com/mile/topic/serivce/dto/CategoryResponse.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
package com.mile.topic.serivce.dto; | ||
|
||
import com.mile.topic.domain.Topic; | ||
|
||
public record CategoryResponse(Long categoryId, String categoryName) { | ||
public static CategoryResponse of(Topic topic) { | ||
return new CategoryResponse(topic.getId(), topic.getKeyword()); | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P1
길이가 0일 경우 예외 처리를 해야할 것 같습니다!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
앗 네 isKeywordsEmpty 에서 0인 경우 예외처리를 하고 있습니다!