DEVELOP-721: removing checkqc threshold check #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aratz
approved these changes
Mar 4, 2024
There was a problem hiding this comment.
Looks good 👍
Just have a suggestion about the PR itself, it's nice if you always write some background in the PR description explaining the problem you're trying to solve, it makes reviewing easier now and it will also make it easier to understand why these changes were made in the future, e.g. in case ticket DEVELOP-721 disappears in JIRA.
|
@Aratz . Thanks for that reminder. I have now updated this PR with the description. |
nkongenelly
force-pushed
the
DEVELOP-721_fix_checkqc_threshold_values_used
branch
from
f0acf22
to
9dac5f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code here has removed ReadsPerSample as the reads per sample threshold was been taken directly from the config, but we need it to be divided with the number of samples in the lane.
This is the quick fix as implementing the reads per sample threshold was only now been used in the flowcell report, and in that one we include all projects.