Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scTenifoldNet + SCORPION Docker + Runners Added #89

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

dosorio
Copy link

@dosorio dosorio commented Feb 6, 2023

Hi,

Thank you for the invitation to collaborate with the Docker and Runners for our methods. I have included them in this PR.

Please let us know if anything else is needed,

Best wishes,

Daniel

dosorio and others added 2 commits February 6, 2023 16:55
@yiqisu
Copy link
Contributor

yiqisu commented Feb 23, 2023

@dosorio Thanks for pulling the request for SCORPION and scTenifoldNet, Dr. Osorio! We are under testing the two algorithms and will merge your PR once the testing is done.

SCORPION works well for synthetic datasets with a number of cells 100, 200, and 500. However, regarding larger numbers of cells, i.e., 2,000 and 5,000, for both synthetic and curated datasets, we got the following error message:

Warning in irlba::irlba(X.for.pca, n.pc) :
  You're computing too large a percentage of total singular values, use a standard svd instead.
Error in if (work <= 1) stop("work must be greater than 1") :
  the condition has length > 1
Calls: <Anonymous> -> <Anonymous>
Execution halted

Since you used the GSD dataset with 2,000 cells in the SCORPION paper, we were wondering if you came across this problem before? If so, could you please provide any instructions on this?

For scTenifoldNet, it sets the default number of components to 9. However, as some synthetic networks in BEELINE have fewer than 9 genes, such as dyn-LI and dyn-BF, there is a problem:

Error in pcNet(X = inputExpr, nComp = 9) :
  nCom should be greater or equal than 2 and lower than the total number of genes
Calls: as.matrix -> pcNet
Execution halted

We'd like to ask your opinion if it is appropriate to change the default value by introducing a parameter to determine the default value for each input network? Thanks a lot!

Best regards,
Yiqi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants