Wrapper PR for: Thompson inner loop, Thompson subcycling bugfix, fix snet bug for Noah LSM #702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ix_thompson_pass_correct_timestep
Merge "Bugfix in Thompson MP, pass correct timestep to core routine" into "Adding inner loop to Thompson microphysics"
…b.com/climbfuji/ccpp-physics into thompson_inner_loop_subcycling_bugfix_noah_bugfix
…into thompson_inner_loop_subcycling_bugfix_noah_bugfix
…ei-noaa/ccpp-physics into thompson_inner_loop_subcycling_bugfix_noah_bugfix
climbfuji
commented
Jul 21, 2021
physics/gcycle.F90
Outdated
| @@ -172,6 +172,13 @@ subroutine gcycle (me, nthrds, nx, ny, isc, jsc, nsst, tile_num, nlunit, | |||
| min_ice(ix) = min_seaice | |||
| endif | |||
|
|
|||
| ZORFCS(ix) = zorll (ix) | |||
There was a problem hiding this comment.
@HelinWei-NOAA @SMoorthi-emc this came in via Helin's PR, is this still correct or does it need to be reverted?
There was a problem hiding this comment.
Done, please check again. Thanks!
|
Please use Moorthi's latest one.
…On Wed, Jul 21, 2021 at 6:02 PM Dom Heinzeller ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In physics/gcycle.F90
<#702 (comment)>:
> @@ -172,6 +172,13 @@ subroutine gcycle (me, nthrds, nx, ny, isc, jsc, nsst, tile_num, nlunit,
min_ice(ix) = min_seaice
endif
+ ZORFCS(ix) = zorll (ix)
@HelinWei-NOAA <https://github.com/HelinWei-NOAA> @SMoorthi-emc
<https://github.com/SMoorthi-emc> this came in via Helin's PR, is this
still correct or does it need to be reverted?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#702 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALPHKYH4QMEVBAOYSGR4GJTTY47YXANCNFSM5AY2BLEA>
.
|
This was referenced Jul 22, 2021
Thanks, I will revert those additional lines. |
climbfuji
requested review from
grantfirl,
JulieSchramm and
llpcarson
as code owners
RuiyuSun
approved these changes
Jul 22, 2021
XiaSun-Atmos
approved these changes
Jul 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR combines several changes:
Issue(s) addressed
Fixes #686
Fixes #669
Testing
See ufs-community/ufs-weather-model#702.
Dependencies
#702
NOAA-EMC/fv3atm#350
ufs-community/ufs-weather-model#702