Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrapper PR for: Thompson inner loop, Thompson subcycling bugfix, remove snet from noah lsm, fix time dimension in restart files #350

Merged
merged 20 commits into from
Jul 23, 2021
Merged

Wrapper PR for: Thompson inner loop, Thompson subcycling bugfix, remove snet from noah lsm, fix time dimension in restart files #350

merged 20 commits into from
Jul 23, 2021

Conversation

climbfuji
Copy link
Collaborator

@climbfuji climbfuji commented Jul 22, 2021 •
edited
Loading

Description

This PR combines many changes:

  • Update of submodule pointers for ccpp-physics for the changes listed below
  • Thompson inner loop from @RuiyuSun
  • Thompson subcycling bugfix from @climbfuji
  • Noah/NoahMP bugfix/remove snet from Noah LSM from @HelinWei-NOAA
  • Fix time dimension in restart files from @climbfuji

Issue(s) addressed

Fixes #348
Fixes #344
Fixes #335

Testing

See ufs-community/ufs-weather-model#702.

Dependencies

NCAR/ccpp-physics#702
#350
ufs-community/ufs-weather-model#702

wx20hw and others added 17 commits June 3, 2021 12:50
fix the snet bug for Noah LSM
50d66fc
update .gitmodules
021e2c5
@HelinWei-NOAA
update branch
fc01b24
@HelinWei-NOAA
correct an error from RTs
68e6fb6
@climbfuji
Update .gitmodules and submodule pointer for ccpp-physics for code re…
01aea57 
…view and testing
@RuiyuSun
adding inner loop namelist variable for the Thompson microphysics
2865f51
@RuiyuSun
update .gitmodules and ccpp/pysics for the inner loop in Thompson mic…
2903940 
…rophysics
@climbfuji
Update submodule pointer for ccpp-physics
70ad914
@climbfuji
Merge branch 'develop' of https://github.com/NOAA-EMC/fv3atm into bug…
293ad3d 
…fix_thompson_pass_correct_timestep
@climbfuji
Update io/FV3GFS_io.F90 so that IC zorl gets read into zorl and not z…
30fbeb1 
…orlw, update logic to compute missing fields
@climbfuji
Merge branch 'develop' of https://github.com/NOAA-EMC/fv3atm into fix…
a4faa90 
…_zorl_in_fv3gfsio
@climbfuji
Rearrange order of fields
b7f3158
@climbfuji
Update .gitmodules and submodule pointer for ccpp-physics for code re…
5f1c842 
…view and testing
@climbfuji
Merge branch 'bugfix_thompson_pass_correct_timestep' of https://githu…
90d77db 
…b.com/climbfuji/fv3atm into thompson_inner_loop_subcycling_bugfix_noah_bugfix
@climbfuji
Merge branch 'innerloop' of https://github.com/RuiyuSun/fv3atm into t…
aad7421 
…hompson_inner_loop_subcycling_bugfix_noah_bugfix
@climbfuji
Merge branch 'remove_snet_from_noah_lsm' of https://github.com/helinw…
6b0ddf6 
…ei-noaa/fv3atm into thompson_inner_loop_subcycling_bugfix_noah_bugfix
@climbfuji
Merge branch 'fix_zorl_in_fv3gfsio' of https://github.com/climbfuji/f…
4f1c1d6 
…v3atm into thompson_inner_loop_subcycling_bugfix_noah_bugfix
@climbfuji climbfuji changed the title Wrapper PR for: Thompson inner loop, Thompson subcycling bugfix, remove snet from noah lsm Wrapper PR for: Thompson inner loop, Thompson subcycling bugfix, remove snet from noah lsm, fix time dimension in restart files Jul 22, 2021
This was referenced Jul 22, 2021
Merged
Merged
@climbfuji climbfuji marked this pull request as ready for review July 22, 2021 15:02
junwang-noaa
junwang-noaa approved these changes Jul 22, 2021
View reviewed changes
Copy link
Collaborator

@junwang-noaa junwang-noaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code look good to me

@climbfuji
Copy link
Collaborator Author

Ready to merge.

@DusanJovic-NOAA DusanJovic-NOAA merged commit 9326cec into NOAA-EMC:develop Jul 23, 2021
This was referenced Jul 23, 2021
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DusanJovic-NOAA DusanJovic-NOAA DusanJovic-NOAA approved these changes

@SMoorthi-emc SMoorthi-emc SMoorthi-emc approved these changes

@junwang-noaa junwang-noaa junwang-noaa approved these changes

@RuiyuSun RuiyuSun Awaiting requested review from RuiyuSun

@HelinWei-NOAA HelinWei-NOAA Awaiting requested review from HelinWei-NOAA

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
6 participants
@climbfuji @junwang-noaa @SMoorthi-emc @DusanJovic-NOAA @HelinWei-NOAA @RuiyuSun