Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrapper PR for: Thompson inner loop, Thompson subcycling bugfix, remove snet from noah lsm, fix time dimension in restart files #350

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
50d66fc
fix the snet bug for Noah LSM
Jun 3, 2021
021e2c5
update .gitmodules
Jun 3, 2021
fc01b24
update branch
HelinWei-NOAA Jun 4, 2021
68e6fb6
correct an error from RTs
HelinWei-NOAA Jun 6, 2021
01aea57
Update .gitmodules and submodule pointer for ccpp-physics for code re…
climbfuji Jun 26, 2021
2865f51
adding inner loop namelist variable for the Thompson microphysics
RuiyuSun Jun 27, 2021
2903940
update .gitmodules and ccpp/pysics for the inner loop in Thompson mic…
RuiyuSun Jun 27, 2021
70ad914
Update submodule pointer for ccpp-physics
climbfuji Jun 28, 2021
293ad3d
Merge branch 'develop' of https://github.com/NOAA-EMC/fv3atm into bug…
climbfuji Jul 1, 2021
30fbeb1
Update io/FV3GFS_io.F90 so that IC zorl gets read into zorl and not z…
climbfuji Jul 16, 2021
a4faa90
Merge branch 'develop' of https://github.com/NOAA-EMC/fv3atm into fix…
climbfuji Jul 16, 2021
b7f3158
Rearrange order of fields
climbfuji Jul 16, 2021
5f1c842
Update .gitmodules and submodule pointer for ccpp-physics for code re…
climbfuji Jul 21, 2021
90d77db
Merge branch 'bugfix_thompson_pass_correct_timestep' of https://githu…
climbfuji Jul 21, 2021
aad7421
Merge branch 'innerloop' of https://github.com/RuiyuSun/fv3atm into t…
climbfuji Jul 21, 2021
6b0ddf6
Merge branch 'remove_snet_from_noah_lsm' of https://github.com/helinw…
climbfuji Jul 22, 2021
4f1c1d6
Merge branch 'fix_zorl_in_fv3gfsio' of https://github.com/climbfuji/f…
climbfuji Jul 22, 2021
616e36a
Update submodule pointer for ccpp-physics
climbfuji Jul 22, 2021
3fd09d0
Bug fixes in io/FV3GFS_io.F90: wrong indices used in several places
climbfuji Jul 22, 2021
ecef817
Revert change to .gitmodules and update submoduel pointer for ccpp-ph…
climbfuji Jul 23, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 18 additions & 10 deletions ccpp/data/GFS_typedefs.F90
Original file line number Diff line number Diff line change
Expand Up @@ -811,6 +811,7 @@ module GFS_typedefs
real(kind=kind_phys) :: ttendlim !< temperature tendency limiter per time step in K/s
logical :: ext_diag_thompson !< flag for extended diagnostic output from Thompson
integer :: thompson_ext_ndiag3d=37 !< number of 3d arrays for extended diagnostic output from Thompson
real(kind=kind_phys) :: dt_inner !< time step for the inner loop in s

!--- GFDL microphysical paramters
logical :: lgfdlmprad !< flag for GFDL mp scheme and radiation consistency
Expand Down Expand Up @@ -2369,6 +2370,10 @@ subroutine sfcprop_create (Sfcprop, IM, Model)
allocate (Sfcprop%weasdl (IM))
! allocate (Sfcprop%hprim (IM))
allocate (Sfcprop%hprime (IM,Model%nmtvr))
allocate(Sfcprop%albdvis_lnd (IM))
allocate(Sfcprop%albdnir_lnd (IM))
allocate(Sfcprop%albivis_lnd (IM))
allocate(Sfcprop%albinir_lnd (IM))
allocate (Sfcprop%emis_lnd (IM))

Sfcprop%slmsk = clear_val
Expand All @@ -2392,6 +2397,10 @@ subroutine sfcprop_create (Sfcprop, IM, Model)
Sfcprop%weasdl = clear_val
! Sfcprop%hprim = clear_val
Sfcprop%hprime = clear_val
Sfcprop%albdvis_lnd = clear_val
Sfcprop%albdnir_lnd = clear_val
Sfcprop%albivis_lnd = clear_val
Sfcprop%albinir_lnd = clear_val
Sfcprop%emis_lnd = clear_val

!--- In (radiation only)
Expand Down Expand Up @@ -2546,20 +2555,12 @@ subroutine sfcprop_create (Sfcprop, IM, Model)
allocate(Sfcprop%iceprv (IM))
allocate(Sfcprop%snowprv (IM))
allocate(Sfcprop%graupelprv(IM))
allocate(Sfcprop%albdvis_lnd (IM))
allocate(Sfcprop%albdnir_lnd (IM))
allocate(Sfcprop%albivis_lnd (IM))
allocate(Sfcprop%albinir_lnd (IM))

Sfcprop%raincprv = clear_val
Sfcprop%rainncprv = clear_val
Sfcprop%iceprv = clear_val
Sfcprop%snowprv = clear_val
Sfcprop%graupelprv = clear_val
Sfcprop%albdvis_lnd = clear_val
Sfcprop%albdnir_lnd = clear_val
Sfcprop%albivis_lnd = clear_val
Sfcprop%albinir_lnd = clear_val
end if
! Noah MP allocate and init when used
!
Expand Down Expand Up @@ -3232,6 +3233,7 @@ subroutine control_initialize (Model, nlunit, fn_nml, me, master, &
real(kind=kind_phys) :: nsradar_reset = -999.0 !< seconds between resetting radar reflectivity calculation, set to <0 for every time step
real(kind=kind_phys) :: ttendlim = -999.0 !< temperature tendency limiter, set to <0 to deactivate
logical :: ext_diag_thompson = .false. !< flag for extended diagnostic output from Thompson
real(kind=kind_phys) :: dt_inner = -999.0 !< time step for the inner loop

!--- GFDL microphysical parameters
logical :: lgfdlmprad = .false. !< flag for GFDLMP radiation interaction
Expand Down Expand Up @@ -3585,7 +3587,7 @@ subroutine control_initialize (Model, nlunit, fn_nml, me, master, &
mg_ncnst, mg_ninst, mg_ngnst, sed_supersat, do_sb_physics, &
mg_alf, mg_qcmin, mg_do_ice_gmao, mg_do_liq_liu, &
ltaerosol, lradar, nsradar_reset, lrefres, ttendlim, &
ext_diag_thompson, lgfdlmprad, &
ext_diag_thompson, dt_inner, lgfdlmprad, &
!--- max hourly
avg_max_length, &
!--- land/surface model control
Expand Down Expand Up @@ -4025,7 +4027,11 @@ subroutine control_initialize (Model, nlunit, fn_nml, me, master, &
Model%nsradar_reset = nsradar_reset
Model%ttendlim = ttendlim
Model%ext_diag_thompson= ext_diag_thompson

if (dt_inner>0) then
Model%dt_inner = dt_inner
else
Model%dt_inner = Model%dtp
endif
!--- F-A MP parameters
Model%rhgrd = rhgrd
Model%spec_adv = spec_adv
Expand Down Expand Up @@ -5093,6 +5099,7 @@ subroutine control_initialize (Model, nlunit, fn_nml, me, master, &
' ltaerosol = ',Model%ltaerosol, &
' ttendlim =',Model%ttendlim, &
' ext_diag_thompson =',Model%ext_diag_thompson, &
' dt_inner =',Model%dt_inner, &
' effr_in =',Model%effr_in, &
' lradar =',Model%lradar, &
' nsradar_reset =',Model%nsradar_reset, &
Expand Down Expand Up @@ -5505,6 +5512,7 @@ subroutine control_print(Model)
print *, ' lrefres : ', Model%lrefres
print *, ' ttendlim : ', Model%ttendlim
print *, ' ext_diag_thompson : ', Model%ext_diag_thompson
print *, ' dt_inner : ', Model%dt_inner
print *, ' '
endif
if (Model%imp_physics == Model%imp_physics_mg) then
Expand Down
7 changes: 7 additions & 0 deletions ccpp/data/GFS_typedefs.meta
Original file line number Diff line number Diff line change
Expand Up @@ -3479,6 +3479,13 @@
units = count
dimensions = ()
type = integer
[dt_inner]
standard_name = time_step_for_inner_loop
long_name = time step for inner loop
units = s
dimensions = ()
type = real
kind = kind_phys
[lgfdlmprad]
standard_name = flag_for_GFDL_microphysics_radiation_interaction
long_name = flag for GFDL microphysics-radiation interaction
Expand Down
Loading