Detect and display error for duplicate reaction names (keys) - Issue #235 #241
+77
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New function MusicBox.check_config() looks at loaded configuration for duplicate reaction names, which cause an array index error if allowed to pass into the solver. We supply diagnostic information so the user may correct the problem in JSON.
In the unit test, reaction rates are implemented as a python list, according to the same convention when loading from JSON. A possible improvement would be to make ReactionList iterable and use that Musica data structure instead.