Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect and display error for duplicate reaction names (keys) - Issue #235 #241

Merged
merged 12 commits into from
Sep 24, 2024
Merged

Detect and display error for duplicate reaction names (keys) - Issue #235 #241

merged 12 commits into from
Sep 24, 2024

Commits on Sep 12, 2024

  1. Adding check for duplicate MUSICA keys.

    carl-drews committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    4d636fc View commit details
    Browse the repository at this point in the history

  2. Removed diagnosic code.

    carl-drews committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    62bb909 View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2024

  1. Added stub for unit test.

    carl-drews committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    ff7a263 View commit details
    Browse the repository at this point in the history

  2. Added the Pass test config.

    carl-drews committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    73c465b View commit details
    Browse the repository at this point in the history

  3. Finalized the test for duplicate reaction names.

    carl-drews committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    69525bc View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2024

  1. Moved from integration tests to unit tests.

    carl-drews committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    ca4358d View commit details
    Browse the repository at this point in the history

  2. Use pytest to verify exception raised.

    carl-drews committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    2a91505 View commit details
    Browse the repository at this point in the history

  3. Removed unneeded imports.

    carl-drews committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    22e5be6 View commit details
    Browse the repository at this point in the history

  4. Simpler assert check for success.

    carl-drews committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    6b8bc64 View commit details
    Browse the repository at this point in the history

  5. Moved the configuration check to within readConditionsFromJson(), and… 

    … at the end.
    carl-drews committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    bbf551c View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2024

  1. Merge branch 'main' into duplicate-keys-235

    @carl-drews
    carl-drews authored Sep 24, 2024
    Configuration menu
    Copy the full SHA
    75bd738 View commit details
    Browse the repository at this point in the history

  2. Fixed indentation mistake.

    carl-drews committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    9ff025d View commit details
    Browse the repository at this point in the history