[production/RRFS.v1] The final physics update PR to RRFS.v1 #841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please specify the ccpp-physics PR that this PR depends on. |
haiqinli
force-pushed
the
production/RRFS.v1-final
branch
from
61055a3
to
cf8d14d
Compare
MatthewPyle-NOAA
changed the title
|
@DusanJovic-NOAA The associated physics PR was ufs-community/ccpp-physics#211 that now has been merged. |
jkbk2004
assigned MatthewPyle-NOAA and DusanJovic-NOAA and unassigned MatthewPyle-NOAA and DusanJovic-NOAA
MatthewPyle-NOAA
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Provide a detailed description of what this PR does. What bug does it fix, or what feature does it add?
-- This is the final physics updates PR to RRFS.v1, and it includes some minor physics bug fixies of RUC LSM, FMS and smoke/dust.
Is a change of answers expected from this PR?
-- Yes, code updates and namelist changes.
Issue(s) addressed
ccpp dependence
ufs-community/ccpp-physics#211
Testing
How were these changes tested? It was tested with RT.
What compilers / HPCs was it tested with? Intel compilers on Hera.
Are the changes covered by regression tests? (If not, why? Do new tests need to be added?) Yes.
Have the ufs-weather-model regression test been run? On what platform?
Yes. /scratch2/BMC/acomp/Haiqin.Li/stmp4/Haiqin.Li/FV3_RT/rt_3775248
Yes, the RT log file of RegressionTests_hera.log is committed.