Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The final physics update PR to RRFS.v1 #211

Conversation

haiqinli
Copy link
Collaborator

@haiqinli haiqinli commented May 28, 2024

This is the final physics updates PR to RRFS.v1, and it includes some minor physics bug fixies of RUC LSM, FMS and smoke/dust.

Copy link
Collaborator

@grantfirl grantfirl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes requested to metadata and comments

Copy link
Collaborator

@dustinswales dustinswales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@haiqinli Thanks for making these changes. Just a few tiny requests.

physics/MP/Thompson/module_mp_thompson.F90 Outdated Show resolved Hide resolved
physics/PBL/MYNN_EDMF/module_bl_mynn.F90 Outdated Show resolved Hide resolved
physics/smoke_dust/rrfs_smoke_wrapper.F90 Outdated Show resolved Hide resolved
@jordanschnell
Copy link

@haiqinli @dustinswales - can I make this change (above for precip_factor) directly or does Haiqin need to do it?

@grantfirl
Copy link
Collaborator

@haiqinli @dustinswales - can I make this change (above for precip_factor) directly or does Haiqin need to do it?

It depends on whether you have push access to Haiqin's fork. If he adds your GitHub user as a collaborator on his fork of ccpp-physics, then you should have push permissions and can make commits.

@haiqinli
Copy link
Collaborator Author

haiqinli commented Jun 5, 2024

@jordanschnell I am back, and I can update the PR to include your changes.

@haiqinli
Copy link
Collaborator Author

haiqinli commented Jun 6, 2024

@grantfirl Some smoke code updates will come next Monday. Let's hold this PR a couple of days. Thanks.

Copy link
Collaborator

@grantfirl grantfirl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes requested to metadata and comments

@grantfirl
Copy link
Collaborator

@haiqinli Do you still want to hold this, or should it be scheduled on the merge queue?

@haiqinli
Copy link
Collaborator Author

@haiqinli Do you still want to hold this, or should it be scheduled on the merge queue?

@grantfirl I am updating this PR, and we can schedule it on the queue. Thanks.

@jkbk2004
Copy link

jkbk2004 commented Aug 2, 2024

@grantfirl @dustinswales @MatthewPyle-NOAA Tests are done at ufs-community/ufs-weather-model#2298. Can you merge this pr?

@MatthewPyle-NOAA
Copy link
Collaborator

@jkbk2004 Ability to merge looks to be held up by an old block.

@dustinswales dustinswales merged commit 5cb99bf into ufs-community:production/RRFS.v1 Aug 3, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants