-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The final physics update PR to RRFS.v1 #211
The final physics update PR to RRFS.v1 #211
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor changes requested to metadata and comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@haiqinli Thanks for making these changes. Just a few tiny requests.
@haiqinli @dustinswales - can I make this change (above for precip_factor) directly or does Haiqin need to do it? |
It depends on whether you have push access to Haiqin's fork. If he adds your GitHub user as a collaborator on his fork of ccpp-physics, then you should have push permissions and can make commits. |
@jordanschnell I am back, and I can update the PR to include your changes. |
@grantfirl Some smoke code updates will come next Monday. Let's hold this PR a couple of days. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor changes requested to metadata and comments
@haiqinli Do you still want to hold this, or should it be scheduled on the merge queue? |
@grantfirl I am updating this PR, and we can schedule it on the queue. Thanks. |
6e878ba
to
2d590da
Compare
@grantfirl @dustinswales @MatthewPyle-NOAA Tests are done at ufs-community/ufs-weather-model#2298. Can you merge this pr? |
@jkbk2004 Ability to merge looks to be held up by an old block. |
5cb99bf
into
ufs-community:production/RRFS.v1
This is the final physics updates PR to RRFS.v1, and it includes some minor physics bug fixies of RUC LSM, FMS and smoke/dust.