-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move the variational scripts to this repository #2920
base: develop
Are you sure you want to change the base?
Move the variational scripts to this repository #2920
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. No comments beyond what others have already said.
This PR needs to be merged before - [NOAA-EMC/global-workflow#2920 It depends on - [NOAA-EMC/jcb-gdas#26 and will require an update to the `jcb-gdas` submodules. It will break the GDASApp marine CI until the `g-w` pr is merged.
# Generate COM variables from templates | ||
YMD=${PDY} HH=${cyc} declare_from_tmpl -rx COM_OBS | ||
|
||
RUN=${GDUMP} YMD=${PDY} HH=${cyc} declare_from_tmpl -rx \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this GDUMP
? This should be RUN
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GDUMP
is associated with the guess
; that is the previous cycle gPDY/gcyc
-- just clarifying why the q.
export CDUMP=${CDUMP:-${RUN:-"gfs"}} | ||
export CDATE=${CDATE:-${PDY}${cyc}} | ||
# Ignore possible spelling error (nothing is misspelled) | ||
# shellcheck disable=SC2153 | ||
export GDUMP=${GDUMP:-"gdas"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I doubt, GDUMP is used in a finalize step, but it might be needed in the __init__
. Just check if that is the case.
@@ -8,11 +8,10 @@ source "${HOMEgfs}/ush/preamble.sh" | |||
status=$? | |||
[[ ${status} -ne 0 ]] && exit "${status}" | |||
|
|||
export job="ocnanalrun" | |||
export jobid="${job}.$$" | |||
export job="marineanlchkpt" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why remove jobid
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no reason, will fix.
Co-authored-by: Rahul Mahajan <[email protected]>
Co-authored-by: Rahul Mahajan <[email protected]>
CI Passed on Hera in Build# 2
|
|
Automated global-workflow Testing Results:
|
CI Passed on Hercules in Build# 3
|
Description
This PR "moves and refactors" the variational DA
exscripts
that were in theGDASapp
to this repository. The ens. var. feature will be replicated/moved in a subsequent PR.Waiting for 2 companion PR's:
ci testing: We should be able to turn on the WCDA test on
Hercules
Type of change
Change characteristics
How has this been tested?
The latest tests were done on
Hecules
, earlier ones onHera
Checklist