Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modern diag manager: Input buffer obj #1362

Merged
merged 3 commits into from
Sep 13, 2023
Merged

Modern diag manager: Input buffer obj #1362

merged 3 commits into from
Sep 13, 2023

Conversation

uramirez8707
Copy link
Contributor

Description

  • Sets up an input buffer object to store the data when running with multiple threads
  • Sets up the math in diag_send_complete
  • The time_none unit tests were updated to run with multiple threads

Fixes # (issue)

How Has This Been Tested?
CI

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included
  • make distcheck passes

@uramirez8707 uramirez8707 requested a review from rem1776 September 8, 2023 15:11
thomas-robinson
thomas-robinson reviewed Sep 11, 2023
View reviewed changes
Copy link
Member

@thomas-robinson thomas-robinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wondering why the has function was removed.

diag_manager/fms_diag_field_object.F90 Show resolved Hide resolved
@thomas-robinson thomas-robinson merged commit e6d8132 into NOAA-GFDL:dmUpdate Sep 13, 2023
17 of 18 checks passed
rem1776 pushed a commit to rem1776/FMS that referenced this pull request May 1, 2024
@uramirez8707
Modern diag manager: Input buffer obj (NOAA-GFDL#1362)
577742d 
* set up an input buffer object and set up the math in diag_send_complete. Turn openmp tests with multiple threads
rem1776 pushed a commit to rem1776/FMS that referenced this pull request May 1, 2024
@uramirez8707
feat: Modern diag manager add input buffer obj (NOAA-GFDL#1362)
f88dabe
rem1776 pushed a commit to rem1776/FMS that referenced this pull request May 1, 2024
@uramirez8707
Modern diag manager: Input buffer obj (NOAA-GFDL#1362)
48c7300 
* set up an input buffer object and set up the math in diag_send_complete. Turn openmp tests with multiple threads
rem1776 pushed a commit to rem1776/FMS that referenced this pull request May 1, 2024
@uramirez8707
feat: Modern diag manager input buffer obj (NOAA-GFDL#1362)
681aa88
rem1776 pushed a commit to rem1776/FMS that referenced this pull request May 1, 2024
@uramirez8707
feat: Modern diag manager input buffer obj (NOAA-GFDL#1362)
8102b78
rem1776 pushed a commit to rem1776/FMS that referenced this pull request May 1, 2024
@uramirez8707
feat: Modern diag manager input buffer obj (NOAA-GFDL#1362)
d4b72d0
rem1776 pushed a commit to rem1776/FMS that referenced this pull request May 1, 2024
@uramirez8707
feat: Modern diag manager input buffer obj (NOAA-GFDL#1362)
2a6da68
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomas-robinson thomas-robinson thomas-robinson left review comments

@rem1776 rem1776 Awaiting requested review from rem1776

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@uramirez8707 @thomas-robinson