Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Hymod and Simple_Lumped #595

Merged
merged 7 commits into from
Aug 8, 2023
Merged

Remove Hymod and Simple_Lumped #595

merged 7 commits into from
Aug 8, 2023

Conversation

mattw-nws
Copy link
Contributor

Builds on/requires #594

More legacy code removal, these two lift out pretty easily and independently.

Additions

  • None

Removals

  • Hymod and simple_lumped model code, related tests and test data.

Changes

Testing

  1. Passes automated tests

Screenshots

Notes

Todos

  • Documentation and examples

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

Testing checklist (automated report can be put here)

Target Environment support

  • Linux

@mattw-nws
Useful notes on example case differences (and whitespace unification)
a676c5d
@mattw-nws
Refactored tests to use BMI test models
70b7449
@mattw-nws
Actually, this is better, especially since we will want 0 extra steps…
32958d4 
… to get test_bmi_cpp for example realization config purposes.
@mattw-nws
Removed test_bmi_c from test_unit tests since it doesn't seem to actu…
b348075 
…ally add any value to have more than one module tested here, and adding it would require different build flags to ngen. Using only the test_bmi_cpp mock, it would be relatively easy in the future to make Bmi_Formulation less "abstract" and support C++ BMI models not in a shared library, removing the need to compile the module in extern explicitly.

Conflicts:
	.github/workflows/test_and_validate.yml
@mattw-nws
Removes simple_lumped--tests passing, docs/examples are TODO.
754f07e
@mattw-nws
Removes Hymod main model--docs and examples are TODO (some files in t…
056f518 
…est/models/hymod are either misplaced or are shared subcomponents of Hymod?)
PhilMiller
PhilMiller reviewed Aug 2, 2023
View reviewed changes
Copy link
Contributor

@PhilMiller PhilMiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once the predecessor PR #594 is merged, I'm +1 on this

@mattw-nws mattw-nws mentioned this pull request Aug 2, 2023
Merged
11 tasks
@mattw-nws mattw-nws self-assigned this Aug 3, 2023
@mattw-nws mattw-nws merged commit 15e763c into NOAA-OWP:master Aug 8, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhilMiller PhilMiller PhilMiller left review comments

@robertbartel robertbartel robertbartel approved these changes

@hellkite500 hellkite500 Awaiting requested review from hellkite500

Assignees

@mattw-nws mattw-nws

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mattw-nws @PhilMiller @robertbartel