Adds datafile text field for Data File object query #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15 +/- ##
=======================================
Coverage 96.01% 96.01%
=======================================
Files 6 6
Lines 602 602
=======================================
Hits 578 578
Misses 24 24 ☔ View full report in Codecov by Sentry. |
pesap
approved these changes
Sep 17, 2024
pesap
pushed a commit
to NREL/R2X
that referenced
this pull request
Sep 18, 2024
…io Filtering (#38) - Ensures ext data can be exported by cleansing it of data which cannot be serialized - Adds variable default property value for cases when variables do not point to a data file - Adds a separate datafile query in `get_model_data` to perform filtering of datafiles where one data_file_tag can specify multiple scenarios of datafiles. This is attached to this PR in plexosdb NREL/plexosdb#15 NOTE: The current implementation for variable and data_file querying is due for a refactor and cleanse... I will make a GitHub issue to specify my thoughts on the best path forward. The current implementation works, with one funky artifact- fields which have datafile scenarios specified, will have their properties duplicated in the output of `get_model_data`. This impacts very few fields since most scenarios are applied to variables instead of datafiles. No impact on results but I throw a warning when duplicate fields replace each others data, but its all correct data replacing other correct data.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For querying Data File objects- I added the field that properly specifies the text of that datafile.