Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address confusion and consistency in powerflow variables #1132

Merged
merged 1 commit into from
Feb 22, 2024
Merged

Address confusion and consistency in powerflow variables #1132

merged 1 commit into from
Feb 22, 2024

Conversation

brtietz
Copy link
Collaborator

@brtietz brtietz commented Feb 19, 2024

  • Use same tolerance in powerflow code and utility rate code, which both generate "electricity from grid to x varaibles"
  • Rename gen_purchases so it's clear that it does not include load it btm models

Fixes NREL/SAM#1684, see the issue for test file.

@brtietz brtietz added this to the 2023 Release Patch 1 milestone Feb 19, 2024
@brtietz brtietz self-assigned this Feb 19, 2024
sjanzou
sjanzou approved these changes Feb 20, 2024
View reviewed changes
Copy link
Collaborator

@sjanzou sjanzou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with files from NREL/SAM#1684

image

@brtietz brtietz merged commit 3041e7c into patch Feb 22, 2024
4 checks passed
@brtietz brtietz deleted the sam_1684_consistent_tolerances branch February 22, 2024 23:32
@brtietz brtietz mentioned this pull request Jul 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjanzou sjanzou sjanzou approved these changes

@cpaulgilman cpaulgilman Awaiting requested review from cpaulgilman

@dguittet dguittet Awaiting requested review from dguittet

Assignees

@brtietz brtietz

Labels
added to release notes
Projects
None yet
Milestone
2023 Release Patch 1
Development

Successfully merging this pull request may close these issues.

Detailed PV and PV-Battery hourly and hourly lifetime discrepancy
3 participants
@brtietz @sjanzou @cpaulgilman