Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates 20240429 with style fixes #83

Merged
merged 6 commits into from
May 3, 2024
Merged

Updates 20240429 with style fixes #83

merged 6 commits into from
May 3, 2024

Conversation

mrakitin
Copy link
Member

Applying the style fixes makes it much simpler to see the diffs and review.

Can replace #82.

@mrakitin
Copy link
Member Author

FYI: adding flake8 checks results in hundreds of check errors, so we are skipping it for now.
It can be added later as in this template:

...
  - repo: https://github.com/pycqa/flake8
    rev: 6.0.0
    hooks:
      - id: flake8
...

@mrakitin mrakitin force-pushed the updates-20240429-with-style-fixes branch from c1d5f11 to fc45928 Compare May 1, 2024 15:35
@mrakitin mrakitin marked this pull request as ready for review May 2, 2024 18:22
hyperrealist
hyperrealist approved these changes May 2, 2024
View reviewed changes
Copy link

@hyperrealist hyperrealist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just one minor comment.

pyCHX/chx_xpcs_xsvs_jupyter_V1.py Outdated Show resolved Hide resolved
XYangXRay
XYangXRay approved these changes May 2, 2024
View reviewed changes
Copy link

@XYangXRay XYangXRay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good for me.

@mrakitin mrakitin merged commit 3225ac8 into main May 3, 2024
12 checks passed
@mrakitin mrakitin deleted the updates-20240429-with-style-fixes branch May 3, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XYangXRay XYangXRay XYangXRay approved these changes

@hyperrealist hyperrealist hyperrealist approved these changes

@thomaswmorris thomaswmorris Awaiting requested review from thomaswmorris

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mrakitin @XYangXRay @hyperrealist