Update linear_congruential_generator with constexpr, tests and a fast discard #6402
+181
−90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
fbusato
requested changes
Nov 3, 2025
Contributor
fbusato
left a comment
fbusato
left a comment
There was a problem hiding this comment.
looks good!
just a couple of nits
| { | ||
| (void) operator()(); | ||
| // minstd_rand and minstd_rand0 can use this efficient implementation | ||
| uint64_t __acc_mult = 1; |
Contributor
There was a problem hiding this comment.
::cuda::std::uint64_t or better in this case using ::cuda::std::uint64_t;
Contributor
Author
There was a problem hiding this comment.
It was suggested in another PR to not use fully qualified namespaces e.g. for ::cuda::std::size_t because we are already in the cuda::std:: namespace. Is something different here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes
Part of #5679
Update linear_congruential_generator with constexpr, stream operators, tests and a fast discard operator for common parameters.