-
Notifications
You must be signed in to change notification settings - Fork 289
Update linear_congruential_generator with constexpr, tests and a fast discard #6402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
RAMitchell
wants to merge
15
commits into
NVIDIA:main
Choose a base branch
from
RAMitchell:lcg-constexpr
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+121
−96
Open
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
14b6631
Pass engine tests
RAMitchell 277693e
Hidden friends
RAMitchell 6871005
Simplify seed
RAMitchell 6c716d5
Fast discard
RAMitchell ade1036
Revert "Simplify seed"
RAMitchell 6b9a8f7
Discard with only multiplier
RAMitchell 3a16ec2
More tests
RAMitchell 99198d6
Merge branch 'main' of github.com:NVIDIA/cccl into lcg-constexpr
RAMitchell 69a4909
Test seed_seq
RAMitchell ade260d
Review comments
RAMitchell a1801c7
Merge branch 'main' of github.com:NVIDIA/cccl into lcg-constexpr
RAMitchell 4355e21
Clang-format
RAMitchell f47e7d2
Uninitialised constexpr variable
RAMitchell 0e4316c
Apply suggestion from @miscco
miscco 2cdb853
Update libcudacxx/include/cuda/std/__random/linear_congruential_engine.h
miscco File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| //===----------------------------------------------------------------------===// | ||
| // | ||
| // Part of libcu++, the C++ Standard Library for your entire system, | ||
| // under the Apache License v2.0 with LLVM Exceptions. | ||
| // See https://llvm.org/LICENSE.txt for license information. | ||
| // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception | ||
| // SPDX-FileCopyrightText: Copyright (c) 2025 NVIDIA CORPORATION & AFFILIATES. | ||
| // | ||
| //===----------------------------------------------------------------------===// | ||
|
|
||
| #include <cuda/std/__random_> | ||
|
|
||
| #include "test_engine.h" | ||
|
|
||
| __host__ __device__ void test() | ||
| { | ||
| test_engine<cuda::std::minstd_rand0, 1043618065u>(); | ||
| test_engine<cuda::std::minstd_rand, 399268537ull>(); | ||
| } | ||
|
|
||
| int main(int, char**) | ||
| { | ||
| test(); | ||
| return 0; | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are we intentionally dropping
[[nodiscard]]? is it only because we are using it internally? or is an expected usage from users?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was not a fan of nodiscard on operator() because a valid use is to advance the state of the engine without using the result. E.g. knuth has algorithms where a generator discards values after seeding. It was pointed out that we can also use discard for this use case. My view is that nodiscard here is overly strict but I don't mind too much - if we do nodiscard I will do it for every engine.