Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix to support multiple single qubit allocations on quantum backends #474

Merged
merged 2 commits into from
Jul 26, 2023

Conversation

schweitzpgi
Copy link
Collaborator

@schweitzpgi schweitzpgi commented Jul 24, 2023

This does not perform any live range analysis and assumes that all qubits for the kernel are allocated, logically, "in parallel" making them all distinct and assigning each a unique integer.

These changes harden the QIR base profile generation pass, making it correct even when other preconditioning passes are absent.

Add test.

Remove singleton deallocs. Handle singleton allocations.

multiple allocations.

This does not perform any live range analysis and assumes that all
qubits for the kernel are allocated, logically, "in parallel" making
them all distinct and assigning each a unique integer.

These changes harden the QIR base profile generation pass, making it
correct even when other preconditioning passes are absent.

Add test.

Remove singleton deallocs. Handle singleton allocations.
Copy link
Collaborator

@amccaskey amccaskey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@schweitzpgi schweitzpgi merged commit 8f8d1d7 into NVIDIA:main Jul 26, 2023
40 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jul 26, 2023
@schweitzpgi schweitzpgi deleted the ch-qir.base.bug branch July 26, 2023 14:37
@schweitzpgi schweitzpgi added this to the release 0.4.1 milestone Sep 25, 2023
@bettinaheim bettinaheim added the bug fix To be listed under Bug Fixes in the release notes label Sep 27, 2023
@bettinaheim bettinaheim changed the title Fix the QIR base profile lowering to handle single qubit allocations and Bug fix to support multiple single qubit allocations on quantum backends Sep 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug fix To be listed under Bug Fixes in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants