Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Exec Parsers - remove individual parser classes #1396

Merged
merged 6 commits into from
Nov 6, 2024
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -21,22 +21,11 @@ import com.nvidia.spark.rapids.tool.qualification.PluginTypeChecker
import org.apache.spark.sql.execution.ui.SparkPlanGraphNode

case class CustomShuffleReaderExecParser(
node: SparkPlanGraphNode,
checker: PluginTypeChecker,
sqlID: Long) extends ExecParser {
override val node: SparkPlanGraphNode,
override val checker: PluginTypeChecker,
override val sqlID: Long) extends GenericExecParser(node, checker,sqlID) {
tgravescs marked this conversation as resolved.
Show resolved Hide resolved

// note this is called either AQEShuffleRead and CustomShuffleReader depending
// on the Spark version, our supported ops list it as CustomShuffleReader
val fullExecName = "CustomShuffleReaderExec"

override def parse: ExecInfo = {
// doesn't have duration
val duration = None
val (speedupFactor, isSupported) = if (checker.isExecSupported(fullExecName)) {
(checker.getSpeedupFactor(fullExecName), true)
} else {
(1.0, false)
}
ExecInfo(node, sqlID, node.name, "", speedupFactor, duration, node.id, isSupported, None)
}
override val fullExecName = "CustomShuffleReaderExec"
tgravescs marked this conversation as resolved.
Show resolved Hide resolved
}

This file was deleted.

This file was deleted.

This file was deleted.

Loading