Spark 4 parquet_writer_test.py fixes #11615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ryan Lee <[email protected]>
|
build |
sql-plugin-api/src/main/scala/com/nvidia/spark/rapids/ShimLoader.scala
Outdated
Show resolved
Hide resolved
Signed-off-by: Ryan Lee <[email protected]>
|
build |
mythrocks
added a commit
to mythrocks/spark-rapids
that referenced
this pull request
Oct 29, 2024
Fixes NVIDIA#11534. This commit fixes the test failures in `parquet_write_test.py`, as listed on NVIDIA#11534. This is an extension of the changes made in NVIDIA#11615, which attempted to address similar failures on Apache Spark 4. Most of the test failures pertain to legacy Parquet writer settings and conf keys which were removed on Spark 4. A stray test involves a change in how the test gleans description strings from exceptions. Signed-off-by: MithunR <[email protected]>
mythrocks
added a commit
that referenced
this pull request
Nov 6, 2024
* Fix Parquet Writer tests on Databricks 14.3 Fixes #11534. This commit fixes the test failures in `parquet_write_test.py`, as listed on #11534. This is an extension of the changes made in #11615, which attempted to address similar failures on Apache Spark 4. Most of the test failures pertain to legacy Parquet writer settings and conf keys which were removed on Spark 4. A stray test involves a change in how the test gleans description strings from exceptions. Signed-off-by: MithunR <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #11024
Fixes test failures caused by some renamed configurations and renamed member variables in spark classes. Also includes a few fixes to the shim loader and integration test runner that allow them to run the preview as if they were the release version.