Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix paddle backend bug and upload missing benchmark files #335

Merged
merged 6 commits into from
Oct 31, 2024

Conversation

HydrogenSulfate
Copy link
Contributor

@HydrogenSulfate HydrogenSulfate commented Oct 29, 2024

Category

  • New feature
  • Bugfix
  • Breaking change
  • Refactoring
  • Documentation
  • Other (please explain)

Description

  1. Due to the variety of device types in Paddle, the processing logic for types in device_from_paddle has been refined.
  2. Sorry for that I forgot to upload two files related to the benchmark. Now they are added in this PR and can be run via:
# benchmark_interop_paddle.py
CUDA_VISIBLE_DEVICES=0 python -m warp.examples.benchmarks.benchmark_interop_paddle

# benchmark_cloth_paddle.py
CUDA_VISIBLE_DEVICES=0 python benchmark_cloth.py paddle_gpu

Changelog

  • Add specific line-by-line info of high level changes in this PR.

Before your PR is "Ready for review"

  • Do you agree to the terms under which contributions are accepted as described in Section 9 the Warp License?
  • Have you read the Contributor Guidelines?
  • Have you written any new necessary tests?
  • Have you added or updated any necessary documentation?
  • Have you added any files modified by compiling Warp and building the documentation to this PR (.e.g. stubs.py, functions.rst)?
  • Does your code pass ruff check and ruff format --check?

warp/paddle.py Outdated Show resolved Hide resolved
warp/tests/test_paddle.py Outdated Show resolved Hide resolved
@shi-eric shi-eric merged commit f26347d into NVIDIA:main Oct 31, 2024
1 check passed
@HydrogenSulfate HydrogenSulfate deleted the bugfix/paddle_backend branch October 31, 2024 04:47
@shi-eric
Copy link
Contributor

Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants