Light miner: Remove dbus container #409
Conversation
| @@ -48,15 +45,12 @@ services: | |||
| - {{I2C_DEVICE}}:{{I2C_DEVICE}} | |||
| restart: on-failure | |||
| environment: | |||
| - DBUS_SYSTEM_BUS_ADDRESS=unix:path=/session/dbus/session_bus_socket | |||
| - FIRMWARE_VERSION={{FIRMWARE_VERSION}} | |||
| - I2C_DEVICE={{I2C_DEVICE}} | |||
There was a problem hiding this comment.
Why do we need this i2c device env variable?
There was a problem hiding this comment.
to detect ecc in the current startup script. Will be removed when we convert startup to python and start using variant information. NebraLtd/hm-gatewayrs#24
settings.ini
Outdated
| @@ -1,9 +1,9 @@ | |||
| [versions] | |||
| FIRMWARE_VERSION=2022.03.07.0-2 | |||
There was a problem hiding this comment.
This should relate to the actual firmware version from gateway-rs
There was a problem hiding this comment.
there is auto bump action for it. but will update it manually for the PR.
There was a problem hiding this comment.
If this is the case, should the auto bump have not done this? Is it actually working?
There was a problem hiding this comment.
If this is the case, should the auto bump have not done this? Is it actually working?
there hasn't been a new release of gateway-rs since it was activated for hm-gatewayrs
There was a problem hiding this comment.
But it should be looking at the FIRMWARE_VERSION here to see if it's up to date?
So clearly isn't working
There was a problem hiding this comment.
Ah I think I know why.... Scheduled workflows have to be in the master branch to work...
pritamghanghas
force-pushed
the
remove_dbus
branch
from
6f51c32 to
3dcfbb7
Compare
| - DBUS_ADDRESS=unix:path=/session/dbus/session_bus_socket | ||
| - FIRMWARE_VERSION={{FIRMWARE_VERSION}} | ||
| - FIRMWARE_SHORT_HASH={{ENV.FIRMWARE_SHORT_HASH}} | ||
|
|
||
| volumes: | ||
| miner-storage: |
There was a problem hiding this comment.
Do we still need miner-storage volume?
There was a problem hiding this comment.
No, I had removed it forgot to stage the change.
There was a problem hiding this comment.
Actually, we probably need to leave this in for cases where people are using a data-only hotspot and want the file based private key to be persistent
There was a problem hiding this comment.
checked all container again, hm-diag uses it for permanent storage.
There was a problem hiding this comment.
Yes and hm-gatewayrs should also use it for persistent key storage for file based key
pritamghanghas
force-pushed
the
remove_dbus
branch
4 times, most recently
from
be65525 to
0c64839
Compare
@shawaj Which one, scheduled workflow one? |
* remove dbus container
pritamghanghas
force-pushed
the
remove_dbus
branch
from
0c64839 to
23c7355
Compare
Yes this one: |
|
Basically I think you will need to do another PR with new workflows to the master branch or the auto-updates won't work |
There was a problem hiding this comment.
As discussed on slack with @pritamghanghas just create new issue for the workflow (if not already there) and all good 👍
Issue
How
Screenshots
References
Checklist