Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sx1302 fixes? #23

Closed
shawaj opened this issue Aug 1, 2021 · 6 comments
Closed

sx1302 fixes? #23

shawaj opened this issue Aug 1, 2021 · 6 comments
Labels
needs-triage question Further information is requested

Comments

@shawaj
Copy link
Member

shawaj commented Aug 1, 2021

We need to determine the reason for the sx1302 fixes and document it.

Additionally investigate if there is a better / more easily maintainable way of handling them.
@shawaj shawaj mentioned this issue Aug 1, 2021
Closed
@shawaj
Copy link
Member Author

shawaj commented Aug 26, 2021 •
edited
Loading

So this is needed to:

  • remove loragw_stts751.o from Makefile
  • remove stts751 includes and functions from loragw_hal.c
  • remove loragw_ad5338r.o from Makefile
  • remove ad5338r includes and functions from loragw_hal.c
  • set fixed temp for sx1302 (instead of using stts751 temp sensor)
  • update config.json locations in lora_pkt_fwd.c

Config json setting:

hm-pktfwd/sx1302fixes/lora_pkt_fwd.c

Lines 74 to 75 in 9d37e84

#define JSON_CONF_DEFAULT "/opt/iotloragateway/packet_forwarder/sx1302/packet_forwarder/global_conf.json"
#define JSON_CONF_LOCAL "/opt/iotloragateway/packet_forwarder/sx1302/packet_forwarder/local_conf.json"

Fixed temp:
helium/sx1302_hal@f33a6e3#diff-f7c83d3744b9002047a15dd7a655dc21a24aa9aa6933bb29229370429e900813

@shawaj shawaj mentioned this issue Aug 26, 2021
Merged
shawaj added a commit that referenced this issue Aug 26, 2021
@shawaj
sx1302: upgrade hal to v2.1.0
011f2c0 
upgrade hal to v2.1.0
- bring in latest repo from upstream
- update dockerfile
- update build script
- update sx1302 fixes (see #23) for updated repo
- remove some unecessary files and code

Closes: #24
shawaj added a commit that referenced this issue Aug 26, 2021
@shawaj
sx1302: upgrade hal to v2.1.0
6cfe6b1 
upgrade hal to v2.1.0
- bring in latest repo from upstream
- update dockerfile
- update build script
- update sx1302 fixes (see #23) for updated repo
- remove some unecessary files and code
- update config.json files to add com_type and com_path and fine_timestamping

Closes: #24
shawaj added a commit that referenced this issue Aug 26, 2021
@shawaj
sx1302: upgrade hal to v2.1.0
41209c6 
upgrade hal to v2.1.0
- bring in latest repo from upstream
- update dockerfile
- update build script
- update sx1302 fixes (see #23) for updated repo
- remove some unecessary files and code
- update config.json files to add com_type and com_path and fine_timestamping

Closes: #24
@shawaj
Copy link
Member Author

shawaj commented Aug 26, 2021 •
edited
Loading

This file isn't currently used https://github.com/NebraLtd/hm-pktfwd/blob/master/sx1302fixes/loragw_gps.c

Need to investigate further why (need to diff with the upstream file https://github.com/Lora-net/sx1302_hal/blob/master/libloragw/src/loragw_gps.c and also https://github.com/RAKWireless/rak_common_for_gateway/blob/master/lora/rak2287/loragw_gps.c )

Lastly check https://github.com/RAKWireless/rak_common_for_gateway/blob/master/lora/rak2287/install.sh

@shawaj
Copy link
Member Author

shawaj commented Aug 26, 2021 •
edited
Loading

See also NebraLtd/packet_forwarder#1 and NebraLtd/lora_gateway#1

@marvinmarnold marvinmarnold added the question Further information is requested label Sep 20, 2021
@shawaj
Copy link
Member Author

shawaj commented Oct 7, 2021 •
edited
Loading

FYI Lora-net/sx1302_hal#58 and Lora-net/sx1302_hal#60 and Lora-net/sx1302_hal#63

@shawaj shawaj mentioned this issue Oct 8, 2021
Merged
marvinmarnold added a commit to NebraLtd/sx1302_hal that referenced this issue Oct 18, 2021
@marvinmarnold
feat: copy process from hm-pktfwd
59492fe 
Deleted unnecessary files and copied in modified
versions where needed. Did not copy
test_loragw_gps.c or test_loragw_gps_i2c.c
because loragw_gps.c is not being used.

hm-pktfwd: https://github.com/NebraLtd/hm-pktfwd/blob/76897fd64383f849b21dabbb0f26558535a95f40/buildfiles/compileSX1302.sh#L5
loragw_gps discussion: NebraLtd/hm-pktfwd#23 (comment)
@marvinmarnold marvinmarnold mentioned this issue Oct 18, 2021
Merged
marvinmarnold added a commit to NebraLtd/sx1302_hal that referenced this issue Oct 20, 2021
@marvinmarnold
feat: copy process from hm-pktfwd
d690c94 
- Deleted unnecessary files and copied in modified versions where needed.
- Did not copy test_loragw_gps.c or test_loragw_gps_i2c.c because loragw_gps.c is not being used.
- Modified reset_lgw.sh according to what was in hm-pktfwd.

hm-pktfwd: https://github.com/NebraLtd/hm-pktfwd/blob/76897fd64383f849b21dabbb0f26558535a95f40/buildfiles/compileSX1302.sh#L5
loragw_gps discussion: NebraLtd/hm-pktfwd#23 (comment)
marvinmarnold added a commit to NebraLtd/sx1302_hal that referenced this issue Oct 20, 2021
@marvinmarnold
feat: copy process from hm-pktfwd
4efe2cc 
- Deleted unnecessary files and copied in modified versions where needed.
- Did not copy test_loragw_gps.c or test_loragw_gps_i2c.c because loragw_gps.c is not being used.
- Modified reset_lgw.sh according to what was in hm-pktfwd.

hm-pktfwd: https://github.com/NebraLtd/hm-pktfwd/blob/76897fd64383f849b21dabbb0f26558535a95f40/buildfiles/compileSX1302.sh#L5
loragw_gps discussion: NebraLtd/hm-pktfwd#23 (comment)
marvinmarnold added a commit to NebraLtd/sx1302_hal that referenced this issue Oct 20, 2021
@marvinmarnold
feat: copy process from hm-pktfwd
acc0770 
- Deleted unnecessary files and copied in modified versions where needed.
- Did not copy test_loragw_gps.c or test_loragw_gps_i2c.c because loragw_gps.c is not being used.
- Modified reset_lgw.sh according to what was in hm-pktfwd.

hm-pktfwd: https://github.com/NebraLtd/hm-pktfwd/blob/76897fd64383f849b21dabbb0f26558535a95f40/buildfiles/compileSX1302.sh#L5
loragw_gps discussion: NebraLtd/hm-pktfwd#23 (comment)
marvinmarnold added a commit to NebraLtd/sx1302_hal that referenced this issue Oct 22, 2021
@marvinmarnold
feat: copy process from hm-pktfwd
d077f3b 
- Deleted unnecessary files and copied in modified versions where needed.
- Did not copy test_loragw_gps.c or test_loragw_gps_i2c.c because loragw_gps.c is not being used.
- Modified reset_lgw.sh according to what was in hm-pktfwd.

hm-pktfwd: https://github.com/NebraLtd/hm-pktfwd/blob/76897fd64383f849b21dabbb0f26558535a95f40/buildfiles/compileSX1302.sh#L5
loragw_gps discussion: NebraLtd/hm-pktfwd#23 (comment)
@shawaj
Copy link
Member Author

shawaj commented Oct 26, 2021

Guess we can probably close this now @marvinmarnold what do you think?

@marvinmarnold
Copy link
Contributor

That makes sense. Do you understand all the changes in this commit? That commit is basically everything that used to be in the sx1302/ directory of this repo.

I would need to carefully go back over all the links above to double check that we understand every single diff. Do you have a better grasp?

@shawaj shawaj mentioned this issue Dec 19, 2021
Closed
@shawaj shawaj mentioned this issue Aug 19, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs-triage question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@vpetersson @marvinmarnold @shawaj @KevinWassermann94