-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added mwan apis #7
Conversation
Might need additional help here @gsanchietti |
I'd say we should validate all data that can breaks the software. |
The only thing that breaks everything is when there's a configuration with the same name as something else. This is extremely dangerous with rules and policies.
|
4d54578
to
6bfddf9
Compare
9e5fbd1
to
bb6030b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there!
I do not expect much performance gain, but transforming a call complexity from O(N) to O(1) is always a good thing!
Added __store_interface helper Added __store_member helper
Added index for policies Added store for policies and rules Added tests Added ValidationError Exception
refactored adding interface
Adding creation APIs for MWAN