Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added mwan APIs #172

Merged
merged 2 commits into from
Sep 29, 2023
Merged

Added mwan APIs #172

merged 2 commits into from
Sep 29, 2023

Conversation

Tbaile
Copy link
Contributor

@Tbaile Tbaile commented Sep 25, 2023

To be merged after: NethServer/python3-nethsec#7

@Tbaile Tbaile force-pushed the mwan_api branch 4 times, most recently from be079fb to 05dc688 Compare September 28, 2023 15:44
@Tbaile Tbaile marked this pull request as ready for review September 28, 2023 15:44
@Tbaile Tbaile requested a review from gsanchietti September 28, 2023 15:45
Copy link
Member

@gsanchietti gsanchietti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the files to the package.
Example from ns.redirects: https://github.com/NethServer/nethsecurity/blob/main/packages/ns-api/Makefile#L94-L95

packages/ns-api/files/ns.mwan Outdated Show resolved Hide resolved
Copy link
Member

@gsanchietti gsanchietti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last few touches

packages/ns-api/files/ns.mwan Outdated Show resolved Hide resolved
@gsanchietti gsanchietti merged commit 90286bf into main Sep 29, 2023
@gsanchietti gsanchietti deleted the mwan_api branch September 29, 2023 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants