Websocket shutdown logic #2277
Open
Websocket shutdown logic #2277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IronGauntlets
force-pushed
the
IronGauntlets/implement-subscribeEvents
branch
2 times, most recently
from
5a713f0 to
bf93293
Compare
pnowosie
approved these changes
Nov 22, 2024
| case <-ctx.Done(): | ||
| // in case websocket connection is closed and server is not in shutdown mode | ||
| // we need to release this goroutine from waiting | ||
| } |
There was a problem hiding this comment.
World you mind to add return here to make it more clear we intend to exit the goroutine?
For me it'd more readable 🤔
| @@ -20,7 +20,7 @@ func testConnection(t *testing.T, ctx context.Context, method jsonrpc.Method, li | |||
| require.NoError(t, rpc.RegisterMethods(method)) | |||
|
|
|||
| // Server | |||
| srv := httptest.NewServer(jsonrpc.NewWebsocket(rpc, utils.NewNopZapLogger())) | |||
| srv := httptest.NewServer(jsonrpc.NewWebsocket(rpc, nil, utils.NewNopZapLogger())) | |||
There was a problem hiding this comment.
According to this article nil channel will block indefinitely, which is I think counter-intuitive.
Maybe it's worth to add a comment that it will block?
| @@ -347,7 +347,7 @@ func TestMultipleSubscribeNewHeadsAndUnsubscribe(t *testing.T) { | |||
| Params: []jsonrpc.Parameter{{Name: "id"}}, | |||
| Handler: handler.Unsubscribe, | |||
| })) | |||
| ws := jsonrpc.NewWebsocket(server, log) | |||
| ws := jsonrpc.NewWebsocket(server, nil, log) | |||
There was a problem hiding this comment.
Also comment about the nil-channel behaviour? (see prev comment)
IronGauntlets
force-pushed
the
IronGauntlets/implement-subscribeEvents
branch
9 times, most recently
from
c218d68 to
301962d
Compare
IronGauntlets
approved these changes
Nov 28, 2024
kirugan
changed the base branch from
IronGauntlets/implement-subscribeEvents
to
main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.