Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Websocket shutdown logic #2277

Merged
merged 10 commits into from
Dec 23, 2024

Merge branch 'main' into kirugan/ws-shutdown

bffd12d
Select commit
Loading
Failed to load commit list.
Merged

Websocket shutdown logic #2277

Merge branch 'main' into kirugan/ws-shutdown
bffd12d
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 23, 2024 in 1s

74.38% (target 70.00%)

View this Pull Request on Codecov

74.38% (target 70.00%)

Details

Codecov Report

Attention: Patch coverage is 75.00000% with 5 lines in your changes missing coverage. Please review.

Project coverage is 74.38%. Comparing base (fce5078) to head (bffd12d).

Files with missing lines Patch % Lines
node/http.go 70.00% 2 Missing and 1 partial ⚠️
jsonrpc/websocket.go 80.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2277      +/-   ##
==========================================
+ Coverage   74.37%   74.38%   +0.01%     
==========================================
  Files         110      110              
  Lines       11531    11546      +15     
==========================================
+ Hits         8576     8589      +13     
- Misses       2287     2289       +2     
  Partials      668      668              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.