Add AVS list to Operator details #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincenthongzy
commented
Aug 16, 2024
| @@ -105,7 +105,7 @@ export default function AVSDetails() { | |||
| cursor: 'rounded border border-outline shadow-none', | |||
| panel: 'p-0', | |||
| tab: 'h-fit p-2', | |||
| tabList: 'rd-box w-full p-2' | |||
| tabList: 'rd-box w-full !overflow-x-scroll p-2' | |||
There was a problem hiding this comment.
@rubo the rd-boxs overflow hidden caused the tab list horizontal scroll to stop working on smaller screens
There was a problem hiding this comment.
It works now on a mobile. What's the problem?
There was a problem hiding this comment.
It fails when there are errors. The error messages causes each tab to be longer than usual, causing tabs to be cut off.
There was a problem hiding this comment.
Got it. I'll check but for this particular container disabling it is ok.
vincenthongzy
requested review from
rubo and
Zishan-7
and removed request for
rubo
Zishan-7
approved these changes
Aug 16, 2024
rubo
reviewed
Aug 16, 2024
| @@ -122,7 +122,7 @@ export default function AVSDetails() { | |||
| </div> | |||
| <div className="flex w-full justify-center"> | |||
| {state.isAVSLoading && ( | |||
| <Skeleton className="mt-2 h-4 w-full rounded-md" /> | |||
| <Skeleton className="mt-2 h-4 w-full min-w-16 rounded-md" /> | |||
There was a problem hiding this comment.
For short texts like "TVL", skeleton expansion is too short. So, added a min width.
rubo
approved these changes
Aug 16, 2024
rubo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After discussing with Clem, simple list for now.