-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add AVS list to Operator details #188
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
1e25e83
Update copy
vincenthongzy 56da50d
Add AVS list in Operator details page
vincenthongzy d1fdc42
Add empty state to AVS list
vincenthongzy 4123d5e
Make AVS list have min height when displaying error message
vincenthongzy 6666913
Shorten property names
rubo 9d0eec0
Set tab skeleton min width
rubo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -105,7 +105,7 @@ export default function AVSDetails() { | |
cursor: 'rounded border border-outline shadow-none', | ||
panel: 'p-0', | ||
tab: 'h-fit p-2', | ||
tabList: 'rd-box w-full p-2' | ||
tabList: 'rd-box w-full !overflow-x-scroll p-2' | ||
}} | ||
disabledKeys={['restakers']} | ||
radius="sm" | ||
|
@@ -122,7 +122,7 @@ export default function AVSDetails() { | |
</div> | ||
<div className="flex w-full justify-center"> | ||
{state.isAVSLoading && ( | ||
<Skeleton className="mt-2 h-4 w-full rounded-md" /> | ||
<Skeleton className="mt-2 h-4 w-full min-w-16 rounded-md" /> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. For short texts like "TVL", skeleton expansion is too short. So, added a min width. |
||
)} | ||
|
||
{state.error && <ErrorMessage error={state.error} />} | ||
|
@@ -158,7 +158,7 @@ export default function AVSDetails() { | |
</div> | ||
<div className="flex w-full justify-center"> | ||
{state.isAVSLoading && ( | ||
<Skeleton className="mt-2 h-4 w-full rounded-md" /> | ||
<Skeleton className="mt-2 h-4 w-full min-w-16 rounded-md" /> | ||
)} | ||
|
||
{state.error && <ErrorMessage error={state.error} />} | ||
|
@@ -187,7 +187,7 @@ export default function AVSDetails() { | |
<div className="text-sm">Restakers</div> | ||
<div className="flex w-full justify-center"> | ||
{state.isAVSLoading && ( | ||
<Skeleton className="mt-2 h-4 w-full rounded-md" /> | ||
<Skeleton className="mt-2 h-4 w-full min-w-16 rounded-md" /> | ||
)} | ||
|
||
{state.error && <ErrorMessage error={state.error} />} | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rubo the
rd-box
s overflow hidden caused the tab list horizontal scroll to stop working on smaller screensThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works now on a mobile. What's the problem?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It fails when there are errors. The error messages causes each tab to be longer than usual, causing tabs to be cut off.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it. I'll check but for this particular container disabling it is ok.