add VITE_CLERK_PUBLISHABLE_KEY and refine terraform code for release #220
Conversation
terraform/Amplify/var.tf
Outdated
There was a problem hiding this comment.
If this whole file is permanently commented out from now onwards, I don't think it's necessary to be included in our codebase
There was a problem hiding this comment.
This file is a hint for next time redeploy production, such as aws account. I spend several hours to figure it out, so I decide to keep it.
terraform/Amplify/main.tf
Outdated
| # It is required when first time to deploy the app | ||
| # oauth_token = var.github_oauth_token | ||
|
|
There was a problem hiding this comment.
If this is permanently commented out from now onwards, I don't think it's necessary to be included in our codebase
There was a problem hiding this comment.
This file is a hint for next time redeploy production, such as aws account. I spent several hours to figure it out, so I decide to keep it.
There was a problem hiding this comment.
IMO it should be in a dedicated README.md or a run book / run script instead of it being a file but with its contents commented out. But yeah its not a blocker.
There was a problem hiding this comment.
Accept it. Remove the file and comments
add domain for production env.
add production deployment branch