-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add VITE_CLERK_PUBLISHABLE_KEY and refine terraform code for release #220
Changes from 2 commits
58c9d60
6ad281f
7f77695
942fd62
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,3 @@ | ||
VITE_API_BASE_URL=https://api.restaking.info | ||
VITE_CLERK_PUBLISHABLE_KEY=pk_test_b3B0aW1hbC1jaGlja2VuLTU3LmNsZXJrLmFjY291bnRzLmRldiQ | ||
VITE_LOG_LEVEL=info |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
|
||
output "aws_amplify_domain_association" { | ||
value = aws_amplify_domain_association.main.sub_domain | ||
} | ||
|
||
output "aws_amplify_webhook"{ | ||
value = aws_amplify_webhook.stage.url | ||
} |
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If this whole file is permanently commented out from now onwards, I don't think it's necessary to be included in our codebase There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This file is a hint for next time redeploy production, such as aws account. I spend several hours to figure it out, so I decide to keep it. |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
#When tHe first time to deploy, github Oauth token is required | ||
#variable "github_oauth_token" { | ||
# description = "GitHub OAuth Token for Amplify" | ||
# type = string | ||
# sensitive = true | ||
#} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this is permanently commented out from now onwards, I don't think it's necessary to be included in our codebase
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is a hint for next time redeploy production, such as aws account. I spent several hours to figure it out, so I decide to keep it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO it should be in a dedicated README.md or a run book / run script instead of it being a file but with its contents commented out. But yeah its not a blocker.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Accept it. Remove the file and comments