Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rpcv02 tests #226

Merged
merged 1 commit into from
Jul 25, 2023
Merged

Fix rpcv02 tests #226

merged 1 commit into from
Jul 25, 2023
+6,921 −705

Conversation

rianhughes
Copy link
Contributor

@rianhughes rianhughes mentioned this pull request Jul 4, 2023
Closed
@rianhughes rianhughes changed the title Fix rp cv02 tests Fix rpcv02 tests Jul 4, 2023
@rianhughes rianhughes marked this pull request as ready for review July 11, 2023 08:38
@rianhughes rianhughes requested review from tarrencev and cicr99 and removed request for tarrencev July 11, 2023 08:38
@cicr99
Copy link
Contributor

cicr99 commented Jul 13, 2023

Some tests are still failing for me on devnet:

  • TestCall on call_test.go
  • TestChainID on provider_test.go
  • TestDeclareTransaction on write_test.go

@cicr99
Copy link
Contributor

cicr99 commented Jul 14, 2023

Also could we update the workflows? Testing RPC v0.2 on devnet is being skipped atm. In addition, testing on testnet is running but is failing, we could skip this step until we manage to fix them as well.
Would love to see a green status

@rianhughes
Copy link
Contributor Author

All tests should pass on mainnet, testnet, devnet, and mock, when making requests to Juno

@rianhughes rianhughes mentioned this pull request Jul 21, 2023
Closed
cicr99
cicr99 reviewed Jul 21, 2023
View reviewed changes
rpcv02/chain.go Show resolved Hide resolved
rpcv02/types.go Show resolved Hide resolved
rpcv02/call_test.go Outdated Show resolved Hide resolved
@rianhughes
Fix RPCv02 tests
90e0706 
Tests now pass on mainnet and testnet
when running against a Juno endpoint.
Mocks and devnet tests also pass.
cicr99
cicr99 approved these changes Jul 25, 2023
View reviewed changes
Copy link
Contributor

@cicr99 cicr99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@cicr99 cicr99 merged commit a4cfd1c into main Jul 25, 2023
1 of 2 checks passed
@cicr99 cicr99 deleted the FixRPCv02Tests branch July 25, 2023 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cicr99 cicr99 cicr99 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rianhughes @cicr99