align system retrieval with nix-build
#1303
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Read the system from the instantiated derivation instead of getting it from the eval time drv attrs.
This is better in terms of correctness as it derives the system through a derivations string context, instead of relying on builder implementations to set the `system` attribute correctly.
This derivation for example did not build with hydra before while it builds fine with the nix repl:
```
:b { name="hello"; type="derivation"; drvPath = hello.drvPath; }
```
roberth
approved these changes
Oct 8, 2023
grahamc
reviewed
Oct 8, 2023
| if (drv->querySystem() == "unknown") | ||
| throw EvalError("derivation must have a 'system' attribute"); | ||
| auto drvContent = state.store->readDerivation(drv->requireDrvPath()); |
There was a problem hiding this comment.
I'm concerned about how much IO this is going to introduce for a project like Nixpkgs.
There was a problem hiding this comment.
I would expect them to still be in the page cache, but we could cache parsed derivations on the Nix side to save some context switches and a little bit of computation.
There was a problem hiding this comment.
Also do we even need to return the system here? I have some doubts that we in fact do.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Read the system from the instantiated derivation instead of getting it from the eval time drv attrs.
This is better in terms of correctness as it derives the system through a derivations string context, instead of relying on builder implementations to set the
systemattribute correctly.This derivation for example did not build with hydra before while it builds fine with the nix repl: