Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

align system retrieval with nix-build #1303

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Commits on Oct 8, 2023

  1. align system retrieval with nix-build

    Read the system from the instantiated derivation instead of getting it from the eval time drv attrs.
    
    This is better in terms of correctness as it derives the system through a derivations string context, instead of relying on builder implementations to set the `system` attribute correctly.
    
    This derivation for example did not build with hydra before while it builds fine with the nix repl:
    
    ```
    :b { name="hello"; type="derivation"; drvPath = hello.drvPath; }
    ```
    DavHau committed Oct 8, 2023
    Configuration menu
    Copy the full SHA
    2387d67 View commit details
    Browse the repository at this point in the history