Better list argument handling #257
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piegamesde
force-pushed
the
list-args
branch
2 times, most recently
from
e8dd22b
to
1638141
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This kind-of-but-not really supersedes #254. It doesn't explicitly touch on list expansion itself, however the part 2 commit implicitly doesn't force-expand last list arguments anymore by virtue of not absorbing them anymore. List expansion will require a fine-tuning pass after this change, notably the question of whether to never expand the last argument if it's a list (as done in #254), because right now it will only do so if the second-to-last argument also is a list.