Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quickgui: add quickemu to PATH #268298

Merged
merged 1 commit into from
May 1, 2024
Merged

quickgui: add quickemu to PATH #268298

merged 1 commit into from
May 1, 2024

Conversation

heyimnova
Copy link
Member

@heyimnova heyimnova commented Nov 18, 2023

Description of changes

Add quickemu to PATH for quickgui so the user does not need to install it separately to use quickgui. Also add license for quickgui, correct meta.platforms, add zenity so the file picker works, and make some other general improvements to the package.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Copy link
Member

@flexiondotorg flexiondotorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I lead the upstream Quickemu project. I have tested these changes locally, and it is an improvement to the user experience as Quickgui works as expected "out of the box" without additional knowledge of having to install quickemu.

@Aleksanaa
Copy link
Member

@ofborg build quickgui

@cole-h cole-h merged commit f4d376b into NixOS:master May 1, 2024
28 of 29 checks passed
Copy link
Contributor

github-actions bot commented May 1, 2024

Successfully created backport PR for release-23.11:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants