Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport release-23.11] quickgui: add quickemu to PATH #308364

Closed

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented May 1, 2024

Bot-based backport to release-23.11, triggered by a label in #268298.

  • Before merging, ensure that this backport is acceptable for the release.
    • Even as a non-commiter, if you find that it is not acceptable, leave a comment.

(cherry picked from commit 585cbc4)
Copy link
Member

@flexiondotorg flexiondotorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I lead the upstream Quickemu project. I have tested these changes locally, and its an improvement to the user experience as Quickgui works as expected "out of the box" without additional knowledge of having to install quickemu.

Tested locally on NixOS 23.11.

@risicle
Copy link
Contributor

risicle commented May 4, 2024

CI failure for the cherry-pick reference

585cbc4 not found in any pickable branch

@flexiondotorg
Copy link
Member

Given that this change has landed in unstable and 24.05 is imminent, I'll close this.

@emilylange emilylange deleted the backport-268298-to-release-23.11 branch May 14, 2024 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants