Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[23.11] vencord: 1.6.4 -> 1.7.8 #305542

Merged
merged 10 commits into from
Apr 24, 2024
Merged

[23.11] vencord: 1.6.4 -> 1.7.8 #305542

merged 10 commits into from
Apr 24, 2024

Conversation

Scrumplex
Copy link
Member

@Scrumplex Scrumplex commented Apr 20, 2024 •
edited by yayayayaka
Loading

Description of changes

Backport of all the bumps to Vencord since 5f3b974893938aed9b01e0b395079648abbeb682

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Scrumplex Scrumplex mentioned this pull request Apr 20, 2024
Merged
13 tasks
@ofborg ofborg bot requested review from NotAShelf, fwam and FlafyDev April 20, 2024 13:17
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Apr 20, 2024
NotAShelf
NotAShelf approved these changes Apr 20, 2024
View reviewed changes
Copy link
Member

@NotAShelf NotAShelf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@wegank wegank added 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Apr 20, 2024
fwam
fwam approved these changes Apr 23, 2024
View reviewed changes
Copy link
Contributor

@fwam fwam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

chëëse, lgtm.

@Scrumplex Scrumplex added 12.approvals: 2 This PR was reviewed and approved by two reputable people needs_merger and removed 12.approvals: 1 This PR was reviewed and approved by one reputable person labels Apr 23, 2024
@yayayayaka
Copy link
Member

Result of nixpkgs-review pr 305542 run on x86_64-linux 1

4 packages built:
  • vencord
  • vencord-web-extension
  • vesktop
  • webcord-vencord

yayayayaka
yayayayaka approved these changes Apr 24, 2024
View reviewed changes
Copy link
Member

@yayayayaka yayayayaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff looking good to me, nixpkgs-review also happy

@yayayayaka yayayayaka merged commit 0f9be0a into NixOS:release-23.11 Apr 24, 2024
29 checks passed
@Scrumplex Scrumplex deleted the pkgs/vencord/23.11-backport-1 branch September 29, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fwam fwam fwam approved these changes

@yayayayaka yayayayaka yayayayaka approved these changes

@NotAShelf NotAShelf NotAShelf approved these changes

@FlafyDev FlafyDev Awaiting requested review from FlafyDev

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 2 This PR was reviewed and approved by two reputable people 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package needs_merger
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Scrumplex @yayayayaka @NotAShelf @fwam @wegank @r-ryantm