graalvm-oracle: init at 22 #321026

farnoy · 2024-06-19T13:21:55Z

Supersedes #259639, resolves #259631

Description of changes

This adds oracle-graalvm and make buildGraalvm more generic to be used on other places than community-edition.

Things done

Pinging @thiagokokada (reviewer from the previous PR)

Add a 👍 reaction to pull requests you find important.

farnoy · 2024-06-19T13:23:34Z

pkgs/top-level/all-packages.nix

  graalvmCEPackages =
    recurseIntoAttrs (callPackage ../development/compilers/graalvm/community-edition { });
  graalvm-ce = graalvmCEPackages.graalvm-ce;
+  graalvm-oracle = callPackage ../development/compilers/graalvm/oracle { };


This used to be called GraalVM EE, now just "Oracle GraalVM". Maybe oracle-graalvm would be a better name here?

rafaelrc7 · 2024-07-20T16:33:25Z

Do you plan on adding the other supported versions by oracle's graalvm? Such as for JDK 17 and 21.

farnoy · 2024-07-25T15:00:36Z

@rafaelrc7 I don't have any use for them but I'll take a look

farnoy · 2024-07-25T15:43:29Z

Rebased on latest nixpkgs to resolve conflicts

rafaelrc7 · 2024-07-25T15:55:11Z

@rafaelrc7 I don't have any use for them but I'll take a look

Thanks! I am currently working on packaging pkl in #286658 and the native build depends on graalvm 17, so it would be a lot of help.

thiagokokada · 2024-07-25T18:33:01Z

pkgs/top-level/all-packages.nix

  graalvmCEPackages = callPackage ../development/compilers/graalvm/community-edition { };
+  graalvmPackages = recurseIntoAttrs (callPackage ../development/compilers/graalvm { });


I don't like that we have 2 different graalvmPackages.

I think since we are introducing Oracle GraamVM again, it is a good time to move everything to graalvmPackages and make graalvmCEPackages an alias to graalvmPackages, and deprecate and eventually remove graalvmCEPackages.

I can do that, but can you be more specific? Do we want graalvmPackages to temporarily be the CE packages and also graalvmPackages.oracle + graalvmPackages.ce as the long-term, stable names?

Do we also want this nesting for JDK packages or is pkgs.oracle-graalvm fine as it is in the current version of the PR?

I can do that, but can you be more specific? Do we want graalvmPackages to temporarily be the CE packages and also graalvmPackages.oracle + graalvmPackages.ce as the long-term, stable names?

Yes. But probably the names will be graalvmPackages.graalvm-oracle and graalvmPackages.graalvm-ce, because there are other packages inside graalvmCEPackages too.

I've updated the PR, please let me know what you think

farnoy · 2024-08-07T19:53:08Z

pkgs/development/compilers/graalvm/graalvm-oracle/hashes.nix

+    "hashes" = {
+      "aarch64-linux" = {
+        sha256 = "1s3ma7x22wqg10cqhdgwj0g9qk3n7bqy10dq6x1vgpljdd41v6dx";
+        url = "https://download.oracle.com/graalvm/17/latest/graalvm-jdk-17_linux-aarch64_bin.tar.gz";


Not sure if this URL is deterministic, there is no /archive/ version for these

farnoy · 2024-08-07T19:53:37Z

pkgs/development/compilers/graalvm/graalvm-oracle/hashes.nix

+        url = "https://download.oracle.com/graalvm/22/archive/graalvm-jdk-22_linux-aarch64_bin.tar.gz";
+      };
+      "x86_64-linux" = {
+        sha256 = "d1860b5b7588310e70b259c891156f6d0cbc34d0d1feec3b37169ed2a415f3c3";


I think these hashes are correct, I calculated them with nix-prefetch-url but I need to double check.

pkgs/by-name/gr/graalvm-ce/package.nix

pkgs/development/compilers/graalvm/graalvm-oracle/hashes.nix

farnoy · 2024-08-09T14:59:59Z

Thanks for the feedback @chayleaf , updated

pkgs/development/compilers/graalvm/default.nix

pkgs/development/compilers/graalvm/graalvm-oracle/hashes.nix

chayleaf · 2024-08-09T21:12:35Z

pkgs/top-level/aliases.nix

+  graalvmCEPackages = graalvmPackages;
+  graalvm-ce = graalvmPackages.graalvm-ce;


Suggested change

graalvmCEPackages = graalvmPackages;

graalvm-ce = graalvmPackages.graalvm-ce;

graalvmCEPackages = graalvmPackages; # 2024-08-10

aliases.nix is for deprecated aliases, so you have to put the date in there as a rough estimate of whether it's okay to replace the alias with a throw (see maintainers/scripts/remove-old-aliases.py)

graalvm-ce is probably fine to not deprecate? in that case, just put it back to all-packages.nix

graalvm-ce now lives in graalvmPackages.graalvm-ce so I'm deprecating this old name #321026 (comment)

thiagokokada · 2024-08-09T21:47:05Z

pkgs/development/compilers/graalvm/graalvm-oracle/hashes.nix

+  "22" = {
+    "aarch64-linux" = {
+      sha256 = "sha256-0wPTDBB2T+qrB27+eQGd88mBsEh/ysPfelMT929hBA4=";
+      url = "https://download.oracle.com/graalvm/22/archive/graalvm-jdk-22_linux-aarch64_bin.tar.gz";


Those URLe are unacceptable, especially in this case since Hydra will not cache the result (because this is unfree).

We need either to have a stable URL from upstream or have the files archived somewhere (e.g.: archive.org).

there are some precedents, but they typically result in the packages being marked as broken (see fmod)

I found more stable links (with full version strings) here.

I'm not sure if this is sufficient from what you're saying. This package will always be unfree, regardless where we download it from? And I'm not sure it's legal to replicate it to archive.org.

the ones with full version strings should be sufficient (there are some for 17 as well)

farnoy · 2024-08-11T14:32:07Z

Updated download links to those for a specific patch version of each package.

thiagokokada · 2024-08-12T08:19:31Z

pkgs/top-level/all-packages.nix

@@ -15879,8 +15879,7 @@ with pkgs;
  openjdk = jdk;
  openjdk_headless = jdk_headless;

-  graalvmCEPackages = callPackage ../development/compilers/graalvm/community-edition { };
-  graalvm-ce = graalvmCEPackages.graalvm-ce;
+  graalvmPackages = recurseIntoAttrs (callPackage ../development/compilers/graalvm { });


I don't like the usage of recurseIntoAttrs here, we probably need to introduce a scope inside graalvmPackages to ensure that all packages are build with the same scope.

I'm not familiar with scopes and not sure what this means. I tried just removing recurseIntoAttrs and things seem to work all the same, so it seems it can be safely dropped?

Is the fact that pkgs/development/compilers/graalvm/graalvm-oracle/default.nix uses graalvmPackages.buildGraalvm (from the parent "scope"?) problematic?

farnoy · 2024-09-02T18:17:02Z

Anything I should do to push this forward?

thiagokokada · 2024-09-02T21:04:55Z

@ofborg build babashka clojure-lsp

thiagokokada · 2024-09-03T21:55:34Z

Build broke for graalvm in darwin. Need to investigate if this is something that is currently broken in master or is something that this branch is doing.

farnoy · 2024-09-08T10:49:46Z

I've had a friend build clojure-lsp and babashka off this branch on aarch64-darwin, and it worked. Not sure what's going wrong when ofborg does it?

nix run github:nixos/nixpkgs#nix-info -- -m
 - system: `"aarch64-darwin"`
 - host os: `Darwin 23.5.0, macOS 14.5`
 - multi-user?: `yes`
 - sandbox: `no`
 - version: `nix-env (Nix) 2.24.5`
 - channels(root): `"nixpkgs"`
 - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixpkgs`

thiagokokada

Please squash your commits accordingly to CONTRIBUTING.md guidelines.

farnoy commented Jun 19, 2024

View reviewed changes

ofborg bot added the 8.has: package (new) label Jun 19, 2024

ofborg bot requested review from hlolli, thiagokokada, bennyandresen, ericdallo and glittershark June 19, 2024 14:23

ofborg bot added 10.rebuild-darwin: 11-100 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Jun 19, 2024

wegank added the 2.status: merge conflict label Jul 4, 2024

rafaelrc7 mentioned this pull request Jul 20, 2024

graalvm-ce: 22.3.1 -> 21.0.0 #257433

Merged

12 tasks

ericdallo and others added 4 commits July 25, 2024 17:41

graalvm-oracle: init at 21

c0003d1

Update graalvm-oracle to 22

f5fb339

Move graalvm-oracle to pkgs/by-name

431d757

Remove graalvm-oracle from all-packages

c7d75e3

farnoy force-pushed the oracle-graalvm branch from 0a176d1 to c7d75e3 Compare July 25, 2024 15:43

ofborg bot removed the 2.status: merge conflict label Jul 25, 2024

thiagokokada reviewed Jul 25, 2024

View reviewed changes

farnoy added 2 commits August 7, 2024 20:45

Fix format

4e10a9a

Reorganize graalvm packages and add graalvm-oracle_17

2cb3ab1

farnoy force-pushed the oracle-graalvm branch from 43d8f95 to 2cb3ab1 Compare August 7, 2024 19:49

Remove the old graalvm-oracle package

fdf484e

farnoy commented Aug 7, 2024

View reviewed changes

Fix format

dadac9a

ofborg bot requested a review from thiagokokada August 7, 2024 20:54

ofborg bot removed 10.rebuild-linux: 1 10.rebuild-linux: 1-10 labels Aug 7, 2024

chayleaf reviewed Aug 7, 2024

View reviewed changes

pkgs/by-name/gr/graalvm-ce/package.nix Outdated Show resolved Hide resolved

chayleaf reviewed Aug 7, 2024

View reviewed changes

pkgs/development/compilers/graalvm/graalvm-oracle/hashes.nix Outdated Show resolved Hide resolved

Address PR feedback

95c5bbb

chayleaf reviewed Aug 9, 2024

View reviewed changes

thiagokokada reviewed Aug 9, 2024

View reviewed changes

farnoy added 2 commits August 10, 2024 15:22

Address review feedback

b53a34d

Use stable download URLs for graalvm-oracle

f6a29e8

farnoy added 2 commits August 11, 2024 16:32

nixfmt

5a3da06

Remove redundant assignment

2e3ddbb

thiagokokada reviewed Aug 12, 2024

View reviewed changes

farnoy added 4 commits August 21, 2024 10:27

Rewrite references to graalvmCEPackages

ef0f803

Fix one more old reference to graalvm-ce

6aa74a7

Fix some more old references to graalvm-ce

8076fdc

Remove even more references to graalvmCEPackages?

0d16cb3

ofborg bot added the 8.has: clean-up label Aug 22, 2024

ofborg bot requested review from thiagokokada, farcaller, jlesquembre and DerGuteMoritz August 22, 2024 15:08

ofborg bot added 10.rebuild-linux: 1-10 and removed 10.rebuild-linux: 11-100 labels Aug 22, 2024

thiagokokada requested changes Sep 20, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

graalvm-oracle: init at 22 #321026

graalvm-oracle: init at 22 #321026

farnoy commented Jun 19, 2024

farnoy Jun 19, 2024

rafaelrc7 commented Jul 20, 2024

farnoy commented Jul 25, 2024

farnoy commented Jul 25, 2024

rafaelrc7 commented Jul 25, 2024

thiagokokada Jul 25, 2024

farnoy Jul 25, 2024

thiagokokada Jul 25, 2024

farnoy Aug 7, 2024

farnoy Aug 7, 2024

farnoy Aug 7, 2024

farnoy commented Aug 9, 2024

chayleaf Aug 9, 2024 •

edited

Loading

farnoy Aug 11, 2024

thiagokokada Aug 9, 2024

chayleaf Aug 9, 2024

farnoy Aug 10, 2024

chayleaf Aug 10, 2024 •

edited

Loading

farnoy commented Aug 11, 2024

thiagokokada Aug 12, 2024

farnoy Aug 14, 2024

farnoy commented Sep 2, 2024

thiagokokada commented Sep 2, 2024

thiagokokada commented Sep 3, 2024

farnoy commented Sep 8, 2024

thiagokokada left a comment

		graalvmCEPackages = callPackage ../development/compilers/graalvm/community-edition { };
		graalvmPackages = recurseIntoAttrs (callPackage ../development/compilers/graalvm { });

		graalvmCEPackages = graalvmPackages;
		graalvm-ce = graalvmPackages.graalvm-ce;

	graalvmCEPackages = graalvmPackages;
	graalvm-ce = graalvmPackages.graalvm-ce;
	graalvmCEPackages = graalvmPackages; # 2024-08-10

graalvm-oracle: init at 22 #321026

Are you sure you want to change the base?

graalvm-oracle: init at 22 #321026

Conversation

farnoy commented Jun 19, 2024

Description of changes

Things done

Choose a reason for hiding this comment

rafaelrc7 commented Jul 20, 2024

farnoy commented Jul 25, 2024

farnoy commented Jul 25, 2024

rafaelrc7 commented Jul 25, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

farnoy commented Aug 9, 2024

chayleaf Aug 9, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

chayleaf Aug 10, 2024 • edited Loading

Choose a reason for hiding this comment

farnoy commented Aug 11, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

farnoy commented Sep 2, 2024

thiagokokada commented Sep 2, 2024

thiagokokada commented Sep 3, 2024

farnoy commented Sep 8, 2024

thiagokokada left a comment

Choose a reason for hiding this comment

chayleaf Aug 9, 2024 •

edited

Loading

chayleaf Aug 10, 2024 •

edited

Loading