-
-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
graalvm-oracle: init at 22 #321026
Open
farnoy
wants to merge
17
commits into
NixOS:master
Choose a base branch
from
farnoy:oracle-graalvm
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
graalvm-oracle: init at 22 #321026
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
c0003d1
graalvm-oracle: init at 21
ericdallo f5fb339
Update graalvm-oracle to 22
farnoy 431d757
Move graalvm-oracle to pkgs/by-name
farnoy c7d75e3
Remove graalvm-oracle from all-packages
farnoy 4e10a9a
Fix format
farnoy 2cb3ab1
Reorganize graalvm packages and add graalvm-oracle_17
farnoy fdf484e
Remove the old graalvm-oracle package
farnoy dadac9a
Fix format
farnoy 95c5bbb
Address PR feedback
farnoy b53a34d
Address review feedback
farnoy f6a29e8
Use stable download URLs for graalvm-oracle
farnoy 5a3da06
nixfmt
farnoy 2e3ddbb
Remove redundant assignment
farnoy ef0f803
Rewrite references to graalvmCEPackages
farnoy 6aa74a7
Fix one more old reference to graalvm-ce
farnoy 8076fdc
Fix some more old references to graalvm-ce
farnoy 0d16cb3
Remove even more references to graalvmCEPackages?
farnoy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
4 changes: 2 additions & 2 deletions
4
pkgs/development/compilers/graalvm/community-edition/graaljs/default.nix
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 2 additions & 2 deletions
4
pkgs/development/compilers/graalvm/community-edition/graalnodejs/default.nix
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 2 additions & 2 deletions
4
pkgs/development/compilers/graalvm/community-edition/graalpy/default.nix
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 2 additions & 2 deletions
4
pkgs/development/compilers/graalvm/community-edition/graalvm-ce/default.nix
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 2 additions & 2 deletions
4
pkgs/development/compilers/graalvm/community-edition/truffleruby/default.nix
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
{ callPackage }: | ||
|
||
let | ||
cePackages = callPackage ./community-edition { }; | ||
in | ||
cePackages | ||
// rec { | ||
buildGraalvm = callPackage ./buildGraalvm.nix; | ||
|
||
graalvm-oracle_22 = callPackage ./graalvm-oracle { version = "22"; }; | ||
graalvm-oracle_17 = callPackage ./graalvm-oracle { version = "17"; }; | ||
graalvm-oracle = graalvm-oracle_22; | ||
} |
16 changes: 16 additions & 0 deletions
16
pkgs/development/compilers/graalvm/graalvm-oracle/default.nix
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
{ | ||
lib, | ||
stdenv, | ||
fetchurl, | ||
graalvmPackages, | ||
useMusl ? false, | ||
version ? "22", | ||
}: | ||
|
||
graalvmPackages.buildGraalvm { | ||
inherit useMusl version; | ||
src = fetchurl (import ./hashes.nix).${version}.${stdenv.system}; | ||
meta.platforms = builtins.attrNames (import ./hashes.nix).${version}; | ||
meta.license = lib.licenses.unfree; | ||
pname = "graalvm-oracle"; | ||
} |
38 changes: 38 additions & 0 deletions
38
pkgs/development/compilers/graalvm/graalvm-oracle/hashes.nix
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,38 @@ | ||
{ | ||
"22" = { | ||
"aarch64-linux" = { | ||
hash = "sha256-E0Fm6mFB7o39pu7JVWOoXT9BdPWiSXBx2hPvlruD5ls="; | ||
url = "https://download.oracle.com/graalvm/22/archive/graalvm-jdk-22.0.1_linux-aarch64_bin.tar.gz"; | ||
}; | ||
"x86_64-linux" = { | ||
hash = "sha256-1YPNsBygI6N+7UXZ0YS2i3qNf1C1jd4TaQQfKUw09KM="; | ||
url = "https://download.oracle.com/graalvm/22/archive/graalvm-jdk-22.0.1_linux-x64_bin.tar.gz"; | ||
}; | ||
"x86_64-darwin" = { | ||
hash = "sha256-waR39L44Ew8wznRc67tYD3HGFZ2UUD4+ELerWnxNpms="; | ||
url = "https://download.oracle.com/graalvm/22/archive/graalvm-jdk-22.0.1_macos-x64_bin.tar.gz"; | ||
}; | ||
"aarch64-darwin" = { | ||
hash = "sha256-dzUVPih81jopuxAx8sAYdwonNOXHyyirUUOhvStK1F8="; | ||
url = "https://download.oracle.com/graalvm/22/archive/graalvm-jdk-22.0.1_macos-aarch64_bin.tar.gz"; | ||
}; | ||
}; | ||
"17" = { | ||
"aarch64-linux" = { | ||
hash = "sha256-0J/XaXGzNyBgxrW1HgUvtBCPPRfAvzwOx67p/QcY4u0="; | ||
url = "https://download.oracle.com/graalvm/17/archive/graalvm-jdk-17.0.11_linux-aarch64_bin.tar.gz"; | ||
}; | ||
"x86_64-linux" = { | ||
hash = "sha256-t0GHR7MGSZDSAGeX7bsI1ziugaP4euRcJq+covDBUYw="; | ||
url = "https://download.oracle.com/graalvm/17/archive/graalvm-jdk-17.0.11_linux-x64_bin.tar.gz"; | ||
}; | ||
"x86_64-darwin" = { | ||
hash = "sha256-q9b6I5hSVt67gkYzUtsJDSi4bPEkzpkoeC5ZyxfqJRc="; | ||
url = "https://download.oracle.com/graalvm/17/archive/graalvm-jdk-17.0.11_macos-x64_bin.tar.gz"; | ||
}; | ||
"aarch64-darwin" = { | ||
hash = "sha256-o4BGCfnD25AVYwG1Ol+2eDVCgiB+mk4I1JBIjyETK6s="; | ||
url = "https://download.oracle.com/graalvm/17/archive/graalvm-jdk-17.0.11_macos-aarch64_bin.tar.gz"; | ||
}; | ||
}; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't like the usage of
recurseIntoAttrs
here, we probably need to introduce a scope insidegraalvmPackages
to ensure that all packages are build with the same scope.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not familiar with scopes and not sure what this means. I tried just removing
recurseIntoAttrs
and things seem to work all the same, so it seems it can be safely dropped?Is the fact that
pkgs/development/compilers/graalvm/graalvm-oracle/default.nix
usesgraalvmPackages.buildGraalvm
(from the parent "scope"?) problematic?