Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maintainers: remove ivar #322266

Merged
merged 2 commits into from
Jun 29, 2024
Merged

maintainers: remove ivar #322266

merged 2 commits into from
Jun 29, 2024

Conversation

eclairevoyant
Copy link
Contributor

@eclairevoyant eclairevoyant commented Jun 24, 2024

Description of changes

CC @IvarWithoutBones if there's any objections.

I've noticed that Ivar has not participated in any reviews for over a year, and the following queries seem to agree.
PRs authored by Ivar
PRs reviewed by Ivar

In accordance with the guidelines here: https://github.com/NixOS/nixpkgs/tree/master/maintainers#how-to-lose-maintainer-status
I am creating this PR to remove Ivar from maintainership, pending any response from them within the next week.

This does unfortunately indicate that a fair number of packages have been abandoned.

Overall retirement tracked under #290642

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: python 6.topic: kernel The Linux kernel 6.topic: policy discussion 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` labels Jun 24, 2024
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jun 24, 2024
@eclairevoyant
Copy link
Contributor Author

eclairevoyant commented Jun 26, 2024

CC @NixOS/dotnet would any committers like to be added to the CODEOWNERS for dotnet paths? (I believe this is limited to committers based on how GH permissions work.)

@eclairevoyant eclairevoyant force-pushed the ivar-remove branch 2 times, most recently from cfa6ac0 to 83c8a68 Compare June 26, 2024 19:28
@corngood
Copy link
Contributor

would any committers like to be added to the CODEOWNERS for dotnet paths?

If there's no way to do this for the 'team', then you can put me in there.

Thanks for cleaning this up. The rest looks good to me.

@eclairevoyant
Copy link
Contributor Author

If there's no way to do this for the 'team', then you can put me in there.

Yeah, the reason I mentioned that only committers can be added is the same reason I can't slap in @NixOS/dotnet in there - it'd basically prevent non-committers from joining that team per my understanding. Anyway I've added you in.

Copy link
Contributor

@drupol drupol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for being picky, but I would do this PR in 2 commits.

  • 1 for removing ivar
  • 1 for adding corngood

@eclairevoyant eclairevoyant added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jun 29, 2024
@drupol drupol merged commit d788dc1 into NixOS:master Jun 29, 2024
21 checks passed
@eclairevoyant eclairevoyant deleted the ivar-remove branch June 29, 2024 14:53
sumnerevans added a commit to nix-community/home-manager that referenced this pull request Jul 3, 2024
ivar was removed as a maintainer from upstream nixpkgs due to
inactivity: NixOS/nixpkgs#322266

Signed-off-by: Sumner Evans <[email protected]>
rycee pushed a commit to nix-community/home-manager that referenced this pull request Jul 3, 2024
ivar was removed as a maintainer from upstream nixpkgs due to
inactivity: NixOS/nixpkgs#322266

Signed-off-by: Sumner Evans <[email protected]>
@AndersonTorres AndersonTorres mentioned this pull request Jul 3, 2024
13 tasks
@eclairevoyant eclairevoyant added the backport release-24.05 Backport PR automatically label Jul 5, 2024
Copy link
Contributor

github-actions bot commented Jul 5, 2024

Backport failed for release-24.05, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release-24.05
git worktree add -d .worktree/backport-322266-to-release-24.05 origin/release-24.05
cd .worktree/backport-322266-to-release-24.05
git switch --create backport-322266-to-release-24.05
git cherry-pick -x 71e728d3b8ad736e4a909231e2d657eeb12a3b6d a90e61f9c576c1af97283bfcdf9bfde3aea37f53

@eclairevoyant eclairevoyant removed the backport release-24.05 Backport PR automatically label Jul 5, 2024
sinanmohd pushed a commit to sinanmohd/home-manager that referenced this pull request Jul 16, 2024
ivar was removed as a maintainer from upstream nixpkgs due to
inactivity: NixOS/nixpkgs#322266

Signed-off-by: Sumner Evans <[email protected]>
rycee pushed a commit to nix-community/home-manager that referenced this pull request Sep 7, 2024
ivar was removed as a maintainer from upstream nixpkgs due to
inactivity: NixOS/nixpkgs#322266

Signed-off-by: Sumner Evans <[email protected]>
(cherry picked from commit 36e2f9d)
PerchunPak pushed a commit to PerchunPak/home-manager that referenced this pull request Sep 17, 2024
ivar was removed as a maintainer from upstream nixpkgs due to
inactivity: NixOS/nixpkgs#322266

Signed-off-by: Sumner Evans <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: kernel The Linux kernel 6.topic: policy discussion 6.topic: python 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants