-
-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
maintainers: remove ivar #322266
maintainers: remove ivar #322266
Conversation
CC @NixOS/dotnet would any committers like to be added to the CODEOWNERS for dotnet paths? (I believe this is limited to committers based on how GH permissions work.) |
cfa6ac0
to
83c8a68
Compare
If there's no way to do this for the 'team', then you can put me in there. Thanks for cleaning this up. The rest looks good to me. |
83c8a68
to
65ec897
Compare
Yeah, the reason I mentioned that only committers can be added is the same reason I can't slap in |
65ec897
to
1944e26
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for being picky, but I would do this PR in 2 commits.
- 1 for removing
ivar
- 1 for adding
corngood
1944e26
to
4e9232d
Compare
4e9232d
to
a90e61f
Compare
ivar was removed as a maintainer from upstream nixpkgs due to inactivity: NixOS/nixpkgs#322266 Signed-off-by: Sumner Evans <[email protected]>
ivar was removed as a maintainer from upstream nixpkgs due to inactivity: NixOS/nixpkgs#322266 Signed-off-by: Sumner Evans <[email protected]>
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release-24.05
git worktree add -d .worktree/backport-322266-to-release-24.05 origin/release-24.05
cd .worktree/backport-322266-to-release-24.05
git switch --create backport-322266-to-release-24.05
git cherry-pick -x 71e728d3b8ad736e4a909231e2d657eeb12a3b6d a90e61f9c576c1af97283bfcdf9bfde3aea37f53 |
ivar was removed as a maintainer from upstream nixpkgs due to inactivity: NixOS/nixpkgs#322266 Signed-off-by: Sumner Evans <[email protected]>
ivar was removed as a maintainer from upstream nixpkgs due to inactivity: NixOS/nixpkgs#322266 Signed-off-by: Sumner Evans <[email protected]> (cherry picked from commit 36e2f9d)
ivar was removed as a maintainer from upstream nixpkgs due to inactivity: NixOS/nixpkgs#322266 Signed-off-by: Sumner Evans <[email protected]>
Description of changes
CC @IvarWithoutBones if there's any objections.
I've noticed that Ivar has not participated in any reviews for over a year, and the following queries seem to agree.
PRs authored by Ivar
PRs reviewed by Ivar
In accordance with the guidelines here: https://github.com/NixOS/nixpkgs/tree/master/maintainers#how-to-lose-maintainer-status
I am creating this PR to remove Ivar from maintainership, pending any response from them within the next week.
This does unfortunately indicate that a fair number of packages have been abandoned.
Overall retirement tracked under #290642
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.