Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

echidna: 2.2.2 -> 2.2.3 #327511

Merged
merged 1 commit into from
Jul 17, 2024
Merged

echidna: 2.2.2 -> 2.2.3 #327511

merged 1 commit into from
Jul 17, 2024

Conversation

hellwolf
Copy link
Contributor

@hellwolf hellwolf commented Jul 15, 2024 •
edited
Loading

Description of changes

Upgrade to 2.2.3 with the latest haskellPackages.

The used patch can be found at: crytic/echidna#1290

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@hellwolf hellwolf mentioned this pull request Jul 15, 2024
Closed
@hellwolf
Copy link
Contributor Author

@ofborg build echidna

@ofborg ofborg bot requested a review from arcz July 16, 2024 02:18
@hellwolf hellwolf marked this pull request as ready for review July 16, 2024 06:08
@hellwolf hellwolf marked this pull request as draft July 16, 2024 10:28
@hellwolf hellwolf marked this pull request as ready for review July 17, 2024 07:54
@hellwolf hellwolf marked this pull request as draft July 17, 2024 07:54
@hellwolf hellwolf marked this pull request as ready for review July 17, 2024 09:18
@hellwolf
Copy link
Contributor Author

deferring 2.2.4 update, due to nixpkgs's hevem is incompatible.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/4268

@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Jul 17, 2024 •
edited
Loading

@ofborg eval

@hellwolf
Copy link
Contributor Author

huh, how the eval failed?

@hellwolf
Copy link
Contributor Author

hellwolf commented Jul 17, 2024 •
edited
Loading

@ofborg eval

@hellwolf
Copy link
Contributor Author

@ofborg build echidna

@SuperSandro2000 SuperSandro2000 merged commit 19107c7 into NixOS:master Jul 17, 2024
26 of 30 checks passed
@hellwolf hellwolf deleted the echidna-2.2.3 branch July 17, 2024 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@arcz arcz Awaiting requested review from arcz

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hellwolf @nixos-discourse @SuperSandro2000