Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support cross platform vty 6.x with vty-crossplatform #1290

Closed
wants to merge 1 commit into from

Conversation

hellwolf
Copy link

@hellwolf hellwolf commented Jul 15, 2024

This is a draft to make the patch visible during fixing echidna in nixpkgs.

I have not updated this repo's flake.nix and fix the build yet..

@CLAassistant
Copy link

CLAassistant commented Jul 15, 2024

CLA assistant check
All committers have signed the CLA.

pure config { inputMap = (Nothing, "\ESC[6;2~", EvKey KPageDown [MShift]) :
(Nothing, "\ESC[5;2~", EvKey KPageUp [MShift]) :
inputMap defaultConfig }
config <- Vty.userConfig
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note:

The standardIOConfig has some unix specific configurations. From 6.x, it is gone. The closest is a function from vty-unix package.

@elopez
Copy link
Member

elopez commented Jul 16, 2024

Hi! to avoid duplicating efforts, please take a look at #1245 which also implements the newer vty

@ggrieco-tob
Copy link
Member

Uhm, I'm wondering if this will solve either #1135 or #1240 🤔

@hellwolf
Copy link
Author

Hi! to avoid duplicating efforts, please take a look at #1245 which also implements the newer vty

Oh, I see! I will try the patch there and see if it passes the nixpkgs build, then I can abandon my own.

@hellwolf
Copy link
Author

I got echidna 2.2.3 fixed for nixpkgs.

I saw 2.2.4 release, but that requires a newer commit of hevm, which is not in nixpkgs yet.

@ggrieco-tob
Copy link
Member

is this still needed?

@hellwolf
Copy link
Author

hellwolf commented Jul 25, 2024

As long as the patch in

https://github.com/NixOS/nixpkgs/blob/nixos-unstable/pkgs/tools/security/echidna/default.nix#L11

      url = "https://github.com/crytic/echidna/commit/2913b027d7e793390ed489ef6a47d23ec9b3c800.patch";

will remain permanent?

@hellwolf hellwolf closed this Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants