Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

morgen: electron_29 -> electron_30 #336026

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

justanotherariel
Copy link
Contributor

Description of changes

Bump electron version from 29 to 30 in response to #335850.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Aug 20, 2024
@justanotherariel justanotherariel added 8.has: package (update) This PR updates a package to a newer version 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Aug 20, 2024
@SigmaSquadron SigmaSquadron added 11.by: package-maintainer This PR was created by the maintainer of the package it changes and removed 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Aug 20, 2024
@SuperSandro2000 SuperSandro2000 merged commit a565780 into NixOS:master Aug 20, 2024
30 of 32 checks passed
@justanotherariel justanotherariel deleted the morgen branch August 20, 2024 11:48
@emilazy emilazy added the backport release-24.05 Backport PR automatically label Aug 25, 2024
Copy link
Contributor

Backport failed for release-24.05, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release-24.05
git worktree add -d .worktree/backport-336026-to-release-24.05 origin/release-24.05
cd .worktree/backport-336026-to-release-24.05
git switch --create backport-336026-to-release-24.05
git cherry-pick -x 4a463f1c60d9e37f34b93a02b713a948c3d833b2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: package (update) This PR updates a package to a newer version 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes backport release-24.05 Backport PR automatically
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants