Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework guile #340618

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from
Draft

Rework guile #340618

wants to merge 7 commits into from
+252 −213

Conversation

AndersonTorres
Copy link
Member

@AndersonTorres AndersonTorres commented Sep 8, 2024 •
edited
Loading

Description of changes

Here I want to cleanup Guile interpreters.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Sep 9, 2024
@ofborg ofborg bot requested a review from vyp September 9, 2024 00:17
@AndersonTorres AndersonTorres force-pushed the rework-guile branch 3 times, most recently from 55a37a7 to 71d3bbc Compare September 14, 2024 02:13
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Sep 27, 2024
@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Oct 4, 2024
@AndersonTorres AndersonTorres force-pushed the rework-guile branch 3 times, most recently from 8210089 to 77a9f81 Compare October 4, 2024 12:13
@AndersonTorres AndersonTorres mentioned this pull request Oct 4, 2024
Merged
13 tasks
@AndersonTorres AndersonTorres force-pushed the rework-guile branch 4 times, most recently from ca76994 to b27ce27 Compare October 4, 2024 18:54
@AndersonTorres AndersonTorres mentioned this pull request Oct 4, 2024
Draft
13 tasks
@AndersonTorres AndersonTorres force-pushed the rework-guile branch 8 times, most recently from 7175eed to e7fa58b Compare October 5, 2024 14:43
@AndersonTorres
guile_1_8_8: migrate to by-name
b7b4282 
And green-alias it to guile_1_8.
@AndersonTorres
guile_1_8_8: refactor
f6f5823 
- nixfmt-rfc-style
- reorder input set
- finalAttrs
- hammer
@AndersonTorres
guile_1_8_8: use fetchFromSavannah
7a1feaf
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Nov 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vyp vyp Awaiting requested review from vyp

Assignees
No one assigned
Labels
2.status: merge conflict This PR has merge conflicts with the target branch 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AndersonTorres @wegank