Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treewide: migrate guile packages to by-name #346423

Merged
merged 5 commits into from
Oct 4, 2024

Conversation

AndersonTorres
Copy link
Member

Picking work from #340618

This is the no-serious-rebuild part.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@AndersonTorres AndersonTorres force-pushed the guile-migrate-to-by-name branch 2 times, most recently from 842b896 to b56ede6 Compare October 4, 2024 13:22
@AndersonTorres AndersonTorres marked this pull request as ready for review October 4, 2024 13:34
@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Oct 4, 2024
@ofborg ofborg bot requested a review from vyp October 4, 2024 13:38
@AndersonTorres AndersonTorres mentioned this pull request Oct 4, 2024
13 tasks
@wegank wegank merged commit 44de13c into NixOS:master Oct 4, 2024
25 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants