nix-serve: unstable-2018-03-20 → unstable-2024-09-17 #342714
Merged
+52
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ofborg test nix-serve |
|
We should probably pin to 2.18 if it isn't merged in one or two days. Better not send a broken nix-serve to nixos-unstable |
|
pinning nix to 2.18 for this package also sounds like an acceptable solution, we could even create a PR and merge that meanwhile + rebase this to remove that pinning. |
13 tasks
…due to breaking changes" This reverts commit ae0a879.
fabianhjr
force-pushed
the
update-nix-serve
branch
from
6504445
to
f6f130b
Compare
|
@ofborg test nix-serve |
|
alternative approach: #342754 |
|
Upstream merged, leaving as draft due to alternative offered by @Mic92 though not closing for the time being. |
Mic92
reviewed
Sep 20, 2024
Mic92
force-pushed
the
update-nix-serve
branch
from
f6f130b
to
0a1ed49
Compare
Mic92
force-pushed
the
update-nix-serve
branch
from
0a1ed49
to
13f5638
Compare
|
This will be broken due to the nix 2.24 revert :s |
|
Indeed. I will pin nix 2.24. |
|
Follow up: #343274 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Draft while upstream decides way forward
edolstra/nix-serve#60
Fixes broken nixosTests.nix-serve after
#335342
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.