Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rapidjson: disable tests which fail to compile #355633

Merged
merged 1 commit into from
Nov 13, 2024
Merged

rapidjson: disable tests which fail to compile #355633

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions pkgs/by-name/ra/rapidjson/char_traits-clang-19-errors.diff
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
diff --git a/test/unittest/writertest.cpp b/test/unittest/writertest.cpp
index 4c24121..66c9087 100644
--- a/test/unittest/writertest.cpp
+++ b/test/unittest/writertest.cpp
@@ -386,6 +386,9 @@ TEST(Writer, InvalidEncoding) {
writer.EndArray();
}

+
+ // does not compile on clang-19
+#if 0
// Fail in encoding
{
StringBuffer buffer;
@@ -401,6 +404,7 @@ TEST(Writer, InvalidEncoding) {
static const UTF32<>::Ch s[] = { 0x110000, 0 }; // Out of U+0000 to U+10FFFF
EXPECT_FALSE(writer.String(s));
}
+#endif
}

TEST(Writer, ValidateEncoding) {
4 changes: 4 additions & 0 deletions pkgs/by-name/ra/rapidjson/package.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,10 @@ stdenv.mkDerivation (finalAttrs: {
./use-nixpkgs-gtest.patch
# https://github.com/Tencent/rapidjson/issues/2214
./suppress-valgrind-failures.patch

# disable tests which don't build on clang-19
# https://github.com/Tencent/rapidjson/issues/2318
./char_traits-clang-19-errors.diff
];

postPatch = ''
Expand Down